Bug 1448472 - Remove a C5037 warning suppression xpcom/string/moz.build that is no longer needed. r=xidorn
authorRyan VanderMeulen <ryanvm@gmail.com>
Sat, 24 Mar 2018 12:19:44 -0400
changeset 772170 a0832da6741d15c722a86ac851c335b1d2be472d
parent 772111 8d4c3cf648d6a9eecb8939df9c4f868570561ec8
child 772171 e81fdb3b711feb859cb780f6d20a291a34c43eaa
push id103870
push userbmo:ntim.bugs@gmail.com
push dateSun, 25 Mar 2018 10:23:38 +0000
reviewersxidorn
bugs1448472
milestone61.0a1
Bug 1448472 - Remove a C5037 warning suppression xpcom/string/moz.build that is no longer needed. r=xidorn
xpcom/string/moz.build
--- a/xpcom/string/moz.build
+++ b/xpcom/string/moz.build
@@ -56,16 +56,9 @@ if CONFIG['INTEL_ARCHITECTURE']:
     SOURCES['nsUTF8UtilsSSE2.cpp'].flags += CONFIG['SSE2_FLAGS']
     SOURCES += ['nsReadableUtilsSSE2.cpp']
     SOURCES['nsReadableUtilsSSE2.cpp'].flags += CONFIG['SSE2_FLAGS']
 
 if CONFIG['BUILD_ARM_NEON'] or CONFIG['CPU_ARCH'] == 'aarch64':
     SOURCES += ['nsUTF8UtilsNEON.cpp']
     SOURCES['nsUTF8UtilsNEON.cpp'].flags += CONFIG['NEON_FLAGS']
 
-# MSVC 2017 has a bug that incorrectly generates C5037 warning which
-# hits the template string code. We need to disable this warning as a
-# workaround. See https://developercommunity.visualstudio.com/
-# content/problem/81223/incorrect-error-c5037-with-permissive.html
-if CONFIG['CC_TYPE'] in ('msvc', 'clang-cl'):
-    CXXFLAGS += ['-wd5037']
-
 FINAL_LIBRARY = 'xul'