Bug 1409341 - Apply background background to tab instead of tab-background on Windows 7. r=dao, a=sledru DEVEDITION_57_0b10_RELEASE FIREFOX_57_0b10_BUILD1 FIREFOX_57_0b10_RELEASE
authorJohann Hofmann <jhofmann@mozilla.com>
Tue, 17 Oct 2017 13:47:18 +0200
changeset 684254 f3271256298ddeea6b13dcd64a26e3943b38aacf
parent 684253 b4aa9ba59cc7cccde5f460f23880c40d18bc5ddc
child 684255 3ff9ebd83d0e7883da3ee60901e2273b94f63064
push id85578
push userbmo:edilee@mozilla.com
push dateFri, 20 Oct 2017 22:43:10 +0000
reviewersdao, sledru
bugs1409341
milestone57.0
Bug 1409341 - Apply background background to tab instead of tab-background on Windows 7. r=dao, a=sledru MozReview-Commit-ID: 4llKxm1rNoq
browser/themes/windows/browser.css
browser/themes/windows/compacttheme.css
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -121,24 +121,28 @@
       color: hsl(240,9%,98%);
     }
 
     /* Always show full-height tab separators on tabs with borders. */
     .tabbrowser-tab:not(:-moz-lwtheme)::before {
       border-image: none !important;
     }
 
-    /* Show the tabs toolbar background color inside tabs on Win 7. */
-    .tab-background:not(:-moz-lwtheme):not([selected=true]) {
+    /* Show border on tabs with background colors and
+     * show the tabs toolbar background color inside tabs. */
+    .tabbrowser-tab:not(:-moz-lwtheme) {
       background-color: hsl(235,33%,19%) !important;
+      border-top: 1px solid var(--tabs-border);
+      background-clip: padding-box;
     }
 
-    /* Show border on tabs with background colors in Windows 7. */
+    /* The top border on top of the tab background is replaced
+     * by the slightly transparent outside tabs-border. */
     .tab-background:not(:-moz-lwtheme) {
-      border-top: 1px solid var(--tabs-border);
+      border-top-style: none !important;
     }
   }
 }
 
 @media (-moz-windows-compositor: 0),
        (-moz-windows-default-theme: 0) {
   /* Please keep the menu text colors in this media block in sync with
    * compacttheme.css, minus the :not(:-moz-lwtheme) condition - see Bug 1165718.
--- a/browser/themes/windows/compacttheme.css
+++ b/browser/themes/windows/compacttheme.css
@@ -82,24 +82,28 @@
     }
   }
 
   /* Always show full-height tab separators on tabs with borders. */
   .tabbrowser-tab::before {
     border-image: none !important;
   }
 
-  /* Show the tabs toolbar background color inside tabs on Win 7. */
-  .tab-background:not([selected=true]) {
+  /* Show border on tabs with background colors and
+   * show the tabs toolbar background color inside tabs. */
+  .tabbrowser-tab {
     background-color: var(--chrome-background-color) !important;
+    border-top: 1px solid var(--tabs-border);
+    background-clip: padding-box;
   }
 
-  /* Show border on tabs with background colors in Windows 7. */
+  /* The top border on top of the tab background is replaced
+   * by the slightly transparent outside tabs-border. */
   .tab-background {
-    border-top: 1px solid var(--tabs-border);
+    border-top-style: none !important;
   }
 
   /* Use default window colors when in non-maximized mode */
   #tabbrowser-tabs,
   #TabsToolbar,
   #browser-panel,
   #titlebar-content {
     background: transparent;