Bug 1256484 - Disable C4456 and C4458 to unblock compilation on VS2015; r?keeler draft
authorGregory Szorc <gps@mozilla.com>
Mon, 14 Mar 2016 16:39:48 -0700
changeset 340300 9c79c5f2c39e27cc0a85304858a0dcb29aaba32a
parent 340258 000b957d08f29701acea6aa48ad18a5aefc96a2c
child 340301 0a741ee8ee919a412bfe8248a173b4cfa402acdd
push id12938
push usergszorc@mozilla.com
push dateTue, 15 Mar 2016 04:41:37 +0000
reviewerskeeler
bugs1256484
milestone48.0a1
Bug 1256484 - Disable C4456 and C4458 to unblock compilation on VS2015; r?keeler As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully someone fixes the underlying problem someday. However, there are tons of ignored warnings in security/certverifier, so I guess the workaround in this patch is par for the course. MozReview-Commit-ID: 7GZ9RpkxnwT
security/certverifier/moz.build
--- a/security/certverifier/moz.build
+++ b/security/certverifier/moz.build
@@ -60,16 +60,22 @@ if CONFIG['_MSC_VER']:
 
   # MSVC 2010's headers trigger these
   CXXFLAGS += [
       '-wd4548', # expression before comma has no effect; ...
       '-wd4668', # 'symbol' is not defined as a preprocessor macro...
       '-wd4987', # nonstandard extension used
   ]
 
+  # MSVC 2015 triggers these
+  CXXFLAGS += [
+      '-wd4456', # declaration of 'rv' hides previous local declaration
+      '-wd4458', # declaration of 'input' hides class member
+  ]
+
   # Gecko headers aren't warning-free enough for us to enable these warnings
   CXXFLAGS += [
     '-wd4100', # 'symbol' : unreferenced formal parameter
     '-wd4127', # conditional expression is constant
     '-wd4946', # reinterpret_cast used between related types
   ]
 
 FINAL_LIBRARY = 'xul'