Bug 1393057 - Remove hover transition from toolbar buttons. r=Gijs
☠☠ backed out by 77a07c56db0d ☠ ☠
authorPhilipp Sackl <philipp@mozilla.com>
Tue, 12 Sep 2017 16:39:45 +0200
changeset 663362 9c55653c204f3ec22b996495a60938b1d3d4037b
parent 663361 0c0dfeb3692a60f3e8f62ee2ee0235fcb5607512
child 663363 32268f6138e0e93ac223c863d9587ff680549764
push id79424
push userbmo:tchiovoloni@mozilla.com
push dateTue, 12 Sep 2017 23:17:54 +0000
reviewersGijs
bugs1393057
milestone57.0a1
Bug 1393057 - Remove hover transition from toolbar buttons. r=Gijs
browser/themes/shared/toolbarbuttons.inc.css
browser/themes/shared/urlbar-searchbar.inc.css
--- a/browser/themes/shared/toolbarbuttons.inc.css
+++ b/browser/themes/shared/toolbarbuttons.inc.css
@@ -119,18 +119,16 @@ toolbar .toolbarbutton-1 > menupopup.cui
 
 .findbar-button > .toolbarbutton-text,
 toolbarbutton.bookmark-item:not(.subviewbutton),
 toolbar .toolbarbutton-1 > .toolbarbutton-icon,
 toolbar .toolbarbutton-1 > .toolbarbutton-text,
 toolbar .toolbarbutton-1 > .toolbarbutton-badge-stack {
   padding: var(--toolbarbutton-inner-padding);
   border-radius: var(--toolbarbutton-border-radius);
-  transition-property: background-color, border-color, box-shadow;
-  transition-duration: var(--toolbarbutton-hover-transition-duration);
 }
 
 toolbar .toolbarbutton-1 > .toolbarbutton-icon {
   /* horizontal padding + actual icon width */
   width: calc(2 * var(--toolbarbutton-inner-padding) + 16px);
 }
 
 .bookmark-item > .toolbarbutton-menu-dropmarker,
@@ -223,16 +221,18 @@ toolbar .toolbarbutton-1[checked]:not(:a
 :root:not([uidensity=compact]) #back-button > .toolbarbutton-icon {
   background-color: var(--backbutton-background);
   background-origin: padding-box;
   background-clip: padding-box;
   border: 1px solid var(--backbutton-border-color);
   border-radius: 10000px;
   width: 32px;
   padding: 7px;
+  transition-property: box-shadow;
+  transition-duration: var(--toolbarbutton-hover-transition-duration);
 }
 
 :root[uidensity=touch] #back-button {
   padding-top: 1px;
   padding-bottom: 1px;
 }
 
 :root[uidensity=touch] #back-button > .toolbarbutton-icon {
--- a/browser/themes/shared/urlbar-searchbar.inc.css
+++ b/browser/themes/shared/urlbar-searchbar.inc.css
@@ -159,18 +159,16 @@
   width: 28px;
   height: 28px;
   /* 28x28 box - 16x16 image = 12x12 padding, 6 on each side */
   padding: 6px;
   -moz-context-properties: fill, fill-opacity;
   fill: currentColor;
   fill-opacity: 0.6;
   color: inherit;
-  transition-property: background-color;
-  transition-duration: var(--toolbarbutton-hover-transition-duration);
 }
 
 :root[uidensity=compact] .urlbar-icon {
   width: 24px;
   height: 24px;
   /* 24x24 box - 16x16 image = 8x8 padding, 4 on each side */
   padding: 4px;
 }