Bug 1388851 - Follow-up to disable parts of browser_webauthn_telemetry.js r=bustage draft
authorTim Taubert <ttaubert@mozilla.com>
Thu, 14 Sep 2017 23:12:13 +0200
changeset 665179 97d8a2caa657aeea81413433f9ea9700ff17a5c2
parent 665178 87cc6f7d362ee6d4423f878ec57bb6e7f405f6c8
child 665180 b8198220ff87fe4758044fb74ed36984855dbdb8
push id79949
push userbmo:jbeich@FreeBSD.org
push dateFri, 15 Sep 2017 00:31:58 +0000
reviewersbustage
bugs1388851
milestone57.0a1
Bug 1388851 - Follow-up to disable parts of browser_webauthn_telemetry.js r=bustage
dom/webauthn/tests/browser/browser_webauthn_telemetry.js
--- a/dom/webauthn/tests/browser/browser_webauthn_telemetry.js
+++ b/dom/webauthn/tests/browser/browser_webauthn_telemetry.js
@@ -77,17 +77,17 @@ add_task(async function test_loopback() 
     is(webauthn_used["U2FSignFinish"], 1, "webauthn_used U2FSignFinish scalar should be 1");
     is(webauthn_used["U2FSignAbort"], undefined, "webauthn_used U2FSignAbort scalar must be unset");
     is(webauthn_used["U2FRegisterAbort"], undefined, "webauthn_used U2FRegisterAbort scalar must be unset");
 
     validateHistogramEntryCount("WEBAUTHN_CREATE_CREDENTIAL_MS", 1);
     validateHistogramEntryCount("WEBAUTHN_GET_ASSERTION_MS", 1);
   }
 
-  {
+  /*{
     cleanupTelemetry();
     // Same as test_successful_loopback, but we will swap to using a (non-existent)
     // usb token. This will cause U2FRegisterAbort to fire, but will not execute the
     // Sign function, and no histogram entries will log.
     Services.prefs.setBoolPref("security.webauth.webauthn", true);
     Services.prefs.setBoolPref("security.webauth.webauthn_enable_softtoken", false);
     Services.prefs.setBoolPref("security.webauth.webauthn_enable_usbtoken", true);
 
@@ -97,13 +97,13 @@ add_task(async function test_loopback() 
     ok(webauthn_used, "Scalar keys are set: " + Object.keys(webauthn_used).join(", "));
     is(webauthn_used["U2FRegisterFinish"], undefined, "webauthn_used U2FRegisterFinish must be unset");
     is(webauthn_used["U2FSignFinish"], undefined, "webauthn_used U2FSignFinish scalar must be unset");
     is(webauthn_used["U2FRegisterAbort"], 1, "webauthn_used U2FRegisterAbort scalar should be a 1");
     is(webauthn_used["U2FSignAbort"], undefined, "webauthn_used U2FSignAbort scalar must be unset");
 
     validateHistogramEntryCount("WEBAUTHN_CREATE_CREDENTIAL_MS", 0);
     validateHistogramEntryCount("WEBAUTHN_GET_ASSERTION_MS", 0);
-  }
+  }*/
 
   // There aren't tests for register succeeding and sign failing, as I don't see an easy way to prompt
   // the soft token to fail that way _and_ trigger the Abort telemetry.
 });