Bug 984463 - Update GeckoEditableListener constants to match IMEMessage constants. r=masayuki
authorJim Chen <nchen@mozilla.com>
Fri, 21 Mar 2014 13:44:59 -0400
changeset 174824 9788a3f558e667ec274cbed4f0cfcc928e9f7031
parent 174823 8f768ced9020344e75d743ef69cbcffd45b0c07f
child 174825 2ff265d0eb77b641497e7d44a00b320ec1432e72
push id1
push userroot
push dateMon, 20 Oct 2014 17:29:22 +0000
reviewersmasayuki
bugs984463
milestone31.0a1
Bug 984463 - Update GeckoEditableListener constants to match IMEMessage constants. r=masayuki
mobile/android/base/GeckoEditable.java
widget/nsIWidget.h
--- a/mobile/android/base/GeckoEditable.java
+++ b/mobile/android/base/GeckoEditable.java
@@ -48,18 +48,18 @@ interface GeckoEditableClient {
 /* interface for the Editable to listen to the Gecko thread
    and also for the IC thread to listen to the Editable */
 interface GeckoEditableListener {
     // IME notification type for notifyIME(), corresponding to NotificationToIME enum in Gecko
     final int NOTIFY_IME_OPEN_VKB = -2;
     final int NOTIFY_IME_REPLY_EVENT = -1;
     final int NOTIFY_IME_OF_FOCUS = 1;
     final int NOTIFY_IME_OF_BLUR = 2;
-    final int NOTIFY_IME_TO_COMMIT_COMPOSITION = 4;
-    final int NOTIFY_IME_TO_CANCEL_COMPOSITION = 5;
+    final int NOTIFY_IME_TO_COMMIT_COMPOSITION = 7;
+    final int NOTIFY_IME_TO_CANCEL_COMPOSITION = 8;
     // IME enabled state for notifyIMEContext()
     final int IME_STATE_DISABLED = 0;
     final int IME_STATE_ENABLED = 1;
     final int IME_STATE_PASSWORD = 2;
     final int IME_STATE_PLUGIN = 3;
 
     void notifyIME(int type);
     void notifyIMEContext(int state, String typeHint,
--- a/widget/nsIWidget.h
+++ b/widget/nsIWidget.h
@@ -477,16 +477,17 @@ struct SizeConstraints {
   {
   }
 
   nsIntSize mMinSize;
   nsIntSize mMaxSize;
 };
 
 // IMEMessage is shared by IMEStateManager and TextComposition.
+// Update values in GeckoEditable.java if you make changes here.
 // XXX Negative values are used in Android...
 enum IMEMessage MOZ_ENUM_TYPE(int8_t)
 {
   // XXX We should replace NOTIFY_IME_OF_CURSOR_POS_CHANGED with
   //     NOTIFY_IME_OF_SELECTION_CHANGE later.
   NOTIFY_IME_OF_CURSOR_POS_CHANGED,
   // An editable content is getting focus
   NOTIFY_IME_OF_FOCUS,