Bug 1016387 - Whitelisting tests that leak Promise rejections (devtools, part 2). r=yoric
authorDavid Rajchenbach-Teller <dteller@mozilla.com>
Fri, 10 Oct 2014 03:56:00 +0200
changeset 209780 9663dfdca20328cdb2fb31736e53fc93c7221287
parent 209779 c795bd58e07846e025a9efcb557ef71cc96660c4
child 209781 4b851bb56ee59d4c470edc8ac91dc62d49a73a0e
push id1
push userroot
push dateMon, 20 Oct 2014 17:29:22 +0000
reviewersyoric
bugs1016387
milestone35.0a1
Bug 1016387 - Whitelisting tests that leak Promise rejections (devtools, part 2). r=yoric
browser/devtools/inspector/test/browser_inspector_highlighter-comments.js
browser/devtools/projecteditor/test/browser_projecteditor_editing_01.js
browser/devtools/projecteditor/test/browser_projecteditor_editors_image.js
browser/devtools/projecteditor/test/browser_projecteditor_immediate_destroy.js
browser/devtools/projecteditor/test/browser_projecteditor_tree_selection_02.js
browser/devtools/responsivedesign/test/browser_responsive_cmd.js
browser/devtools/shared/test/browser_toolbar_tooltip.js
--- a/browser/devtools/inspector/test/browser_inspector_highlighter-comments.js
+++ b/browser/devtools/inspector/test/browser_inspector_highlighter-comments.js
@@ -1,15 +1,22 @@
 /* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
 /* vim: set ts=2 et sw=2 tw=80: */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 "use strict";
 
+///////////////////
+//
+// Whitelisting this test.
+// As part of bug 1077403, the leaking uncaught rejection should be fixed.
+//
+thisTestLeaksUncaughtRejectionsAndShouldBeFixed("false");
+
 // Test that hovering over the markup-view's containers doesn't always show the
 // highlighter, depending on the type of node hovered over.
 
 const TEST_PAGE = TEST_URL_ROOT +
   "doc_inspector_highlighter-comments.html";
 
 let test = asyncTest(function* () {
   let { inspector } = yield openInspectorForURL(TEST_PAGE);
--- a/browser/devtools/projecteditor/test/browser_projecteditor_editing_01.js
+++ b/browser/devtools/projecteditor/test/browser_projecteditor_editing_01.js
@@ -1,14 +1,21 @@
 /* vim: set ts=2 et sw=2 tw=80: */
 /* Any copyright is dedicated to the Public Domain.
  http://creativecommons.org/publicdomain/zero/1.0/ */
 
 "use strict";
 
+///////////////////
+//
+// Whitelisting this test.
+// As part of bug 1077403, the leaking uncaught rejection should be fixed.
+//
+thisTestLeaksUncaughtRejectionsAndShouldBeFixed("destroy");
+
 loadHelperScript("helper_edits.js");
 
 // Test ProjectEditor basic functionality
 let test = asyncTest(function*() {
   let projecteditor = yield addProjectEditorTabForTempDirectory();
   let TEMP_PATH = projecteditor.project.allPaths()[0];
 
   is (getTempFile("").path, TEMP_PATH, "Temp path is set correctly.");
--- a/browser/devtools/projecteditor/test/browser_projecteditor_editors_image.js
+++ b/browser/devtools/projecteditor/test/browser_projecteditor_editors_image.js
@@ -1,14 +1,21 @@
 /* vim: set ts=2 et sw=2 tw=80: */
 /* Any copyright is dedicated to the Public Domain.
  http://creativecommons.org/publicdomain/zero/1.0/ */
 
 "use strict";
 
+///////////////////
+//
+// Whitelisting this test.
+// As part of bug 1077403, the leaking uncaught rejection should be fixed.
+//
+thisTestLeaksUncaughtRejectionsAndShouldBeFixed("destroy");
+
 loadHelperScript("helper_edits.js");
 
 // Test ProjectEditor image editor functionality
 let test = asyncTest(function*() {
   let projecteditor = yield addProjectEditorTabForTempDirectory();
   let TEMP_PATH = projecteditor.project.allPaths()[0];
 
   is (getTempFile("").path, TEMP_PATH, "Temp path is set correctly.");
--- a/browser/devtools/projecteditor/test/browser_projecteditor_immediate_destroy.js
+++ b/browser/devtools/projecteditor/test/browser_projecteditor_immediate_destroy.js
@@ -1,14 +1,21 @@
 /* vim: set ts=2 et sw=2 tw=80: */
 /* Any copyright is dedicated to the Public Domain.
  http://creativecommons.org/publicdomain/zero/1.0/ */
 
 "use strict";
 
+///////////////////
+//
+// Whitelisting this test.
+// As part of bug 1077403, the leaking uncaught rejection should be fixed.
+//
+thisTestLeaksUncaughtRejectionsAndShouldBeFixed("destroy");
+
 // Test that projecteditor can be destroyed in various states of loading
 // without causing any leaks or exceptions.
 
 let test = asyncTest(function* () {
 
   info ("Testing tab closure when projecteditor is in various states");
   let loaderUrl = "chrome://browser/content/devtools/projecteditor-test.xul";
 
--- a/browser/devtools/projecteditor/test/browser_projecteditor_tree_selection_02.js
+++ b/browser/devtools/projecteditor/test/browser_projecteditor_tree_selection_02.js
@@ -1,14 +1,21 @@
 /* vim: set ts=2 et sw=2 tw=80: */
 /* Any copyright is dedicated to the Public Domain.
  http://creativecommons.org/publicdomain/zero/1.0/ */
 
 "use strict";
 
+///////////////////
+//
+// Whitelisting this test.
+// As part of bug 1077403, the leaking uncaught rejection should be fixed.
+//
+thisTestLeaksUncaughtRejectionsAndShouldBeFixed("destroy");
+
 // Test that files get reselected in the tree when their editor
 // is focused.  https://bugzilla.mozilla.org/show_bug.cgi?id=1011116.
 
 let test = asyncTest(function*() {
   let projecteditor = yield addProjectEditorTabForTempDirectory();
   let TEMP_PATH = projecteditor.project.allPaths()[0];
 
   is (getTempFile("").path, TEMP_PATH, "Temp path is set correctly.");
--- a/browser/devtools/responsivedesign/test/browser_responsive_cmd.js
+++ b/browser/devtools/responsivedesign/test/browser_responsive_cmd.js
@@ -1,11 +1,18 @@
 /* Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/ */
 
+///////////////////
+//
+// Whitelisting this test.
+// As part of bug 1077403, the leaking uncaught rejection should be fixed.
+//
+thisTestLeaksUncaughtRejectionsAndShouldBeFixed("destroy");
+
 function test() {
   function isOpen() {
     return !!gBrowser.selectedTab.__responsiveUI;
   }
 
   helpers.addTabWithToolbar("about:blank", function(options) {
     return helpers.audit(options, [
       {
--- a/browser/devtools/shared/test/browser_toolbar_tooltip.js
+++ b/browser/devtools/shared/test/browser_toolbar_tooltip.js
@@ -1,13 +1,20 @@
 /* Any copyright is dedicated to the Public Domain.
    http://creativecommons.org/publicdomain/zero/1.0/ */
 
 // Tests that the developer toolbar works properly
 
+///////////////////
+//
+// Whitelisting this test.
+// As part of bug 1077403, the leaking uncaught rejection should be fixed.
+//
+thisTestLeaksUncaughtRejectionsAndShouldBeFixed("Protocol error (unknownError): Error: Got an invalid root window in DocumentWalker");
+
 const TEST_URI = "data:text/html;charset=utf-8,<p>Tooltip Tests</p>";
 
 function test() {
   addTab(TEST_URI, function() {
     Task.spawn(runTest).catch(err => {
       ok(false, ex);
       console.error(ex);
     }).then(finish);