Bug 1275437 - Changed flags passed to pacman in Windows bootstrapper to be the --long-form instead of the single character flag. r?gps draft
authorNathan Hakkakzadeh <nhakkakzadeh@mozilla.com>
Wed, 25 May 2016 14:20:38 -0700
changeset 371054 95e95e8d589346b2823914cfdf4ac0dfc4092efa
parent 371053 ca39b7213ad42ea3591d6149a46fc33d5b8d9027
child 521898 ec83b864702250b0db41b6f46edc6284a834fe67
push id19222
push userbmo:nhakkakzadeh@mozilla.com
push dateWed, 25 May 2016 21:49:35 +0000
reviewersgps
bugs1275437
milestone49.0a1
Bug 1275437 - Changed flags passed to pacman in Windows bootstrapper to be the --long-form instead of the single character flag. r?gps This will make it easier to read for people who are not familiar with pacman. MozReview-Commit-ID: BDzSV8GZ7er
python/mozboot/mozboot/windows.py
--- a/python/mozboot/mozboot/windows.py
+++ b/python/mozboot/mozboot/windows.py
@@ -68,22 +68,24 @@ class WindowsBootstrapper(BaseBootstrapp
 
     def _update_package_manager(self):
         self.pacman_update()
 
     def run(self, command):
         subprocess.check_call(command, stdin=sys.stdin)
 
     def pacman_update(self):
-        command = ['pacman', '-S', '--refresh']
+        command = ['pacman', '--sync', '--refresh']
         self.run(command)
 
     def pacman_upgrade(self):
-        command = ['pacman', '-Syu']
+        command = ['pacman', '--sync', '--refresh', '--sysupgrade']
         self.run(command)
 
     def pacman_install(self, *packages):
-        command = ['pacman', '-S', '--needed']
+        command = ['pacman', '--sync', '--needed']
         if self.no_interactive:
             command.append('--noconfirm')
 
         command.extend(packages)
         self.run(command)
+
+