Bug 1416106 - Part 3: Implement compositor warning. r?gl draft
authorDaisuke Akatsuka <dakatsuka@mozilla.com>
Wed, 14 Feb 2018 16:27:24 +0900
changeset 754849 90bce310a1aad1350bfc377b18eb20775999c7ba
parent 754848 cb7fab62c11ced8a2f257a3e13c85977b85628e5
child 754850 56bb1d40c668ed03534867ff3eed83301eb6f53c
push id99015
push userbmo:dakatsuka@mozilla.com
push dateWed, 14 Feb 2018 11:58:26 +0000
reviewersgl
bugs1416106
milestone60.0a1
Bug 1416106 - Part 3: Implement compositor warning. r?gl MozReview-Commit-ID: 18qQ1FydML4
devtools/client/inspector/animation/components/AnimatedPropertyName.js
devtools/client/themes/animation.css
--- a/devtools/client/inspector/animation/components/AnimatedPropertyName.js
+++ b/devtools/client/inspector/animation/components/AnimatedPropertyName.js
@@ -20,17 +20,19 @@ class AnimatedPropertyName extends PureC
     const {
       property,
       state,
     } = this.props;
 
     return dom.div(
       {
         className: "animated-property-name" +
-                   (state && state.runningOnCompositor ? " compositor" : ""),
+                   (state && state.runningOnCompositor ? " compositor" : "") +
+                   (state && state.warning ? " warning" : ""),
+        title: state ? state.warning : "",
       },
       dom.span(
         {},
         property
       )
     );
   }
 }
--- a/devtools/client/themes/animation.css
+++ b/devtools/client/themes/animation.css
@@ -347,16 +347,20 @@
   fill: var(--fast-track-color);
   height: 100%;
   position: absolute;
   left: 0;
   width: 15px;
   -moz-context-properties: fill;
 }
 
+.animated-property-name.warning span {
+  text-decoration: underline dotted;
+}
+
 /* No Animation Panel */
 .animation-error-message {
   overflow: auto;
 }
 
 .animation-error-message > p {
   white-space: pre;
 }