Bug 1261993 - [infer] Errors in DefaultDoorHanger. r=mcomella
authorChenxia Liu <liuche@mozilla.com>
Thu, 21 Apr 2016 16:24:39 -0700
changeset 362667 9015ebea629332d283c11fdb8c525d5c1d20c8d2
parent 362666 f410732bf7cf3cd523e68ff056a0a4c66b4fde94
child 362668 e5344982b8ec6626882230f6f348303cf3201d12
child 362671 8381e018c7efe711392dc1b1e6d43ff84e078349
child 362793 9f866b72af4a3c4520205d55c60aa74548682c4a
push id17008
push userbgrinstead@mozilla.com
push dateMon, 02 May 2016 21:59:43 +0000
reviewersmcomella
bugs1261993
milestone49.0a1
Bug 1261993 - [infer] Errors in DefaultDoorHanger. r=mcomella MozReview-Commit-ID: AemVFuiMNjo
mobile/android/base/java/org/mozilla/gecko/prompts/PromptInput.java
--- a/mobile/android/base/java/org/mozilla/gecko/prompts/PromptInput.java
+++ b/mobile/android/base/java/org/mozilla/gecko/prompts/PromptInput.java
@@ -30,29 +30,29 @@ import android.widget.ArrayAdapter;
 import android.widget.CheckBox;
 import android.widget.DatePicker;
 import android.widget.EditText;
 import android.widget.LinearLayout;
 import android.widget.Spinner;
 import android.widget.TextView;
 import android.widget.TimePicker;
 
-public class PromptInput {
+public abstract class PromptInput {
     protected final String mLabel;
     protected final String mType;
     protected final String mId;
     protected final String mValue;
     protected final String mMinValue;
     protected final String mMaxValue;
     protected OnChangeListener mListener;
     protected View mView;
     public static final String LOGTAG = "GeckoPromptInput";
 
     public interface OnChangeListener {
-        public void onChange(PromptInput input);
+        void onChange(PromptInput input);
     }
 
     public void setListener(OnChangeListener listener) {
         mListener = listener;
     }
 
     public static class EditInput extends PromptInput {
         protected final String mHint;
@@ -367,19 +367,17 @@ public class PromptInput {
                 }
 
                 break;
         }
 
         return null;
     }
 
-    public View getView(Context context) throws UnsupportedOperationException {
-        return null;
-    }
+    public abstract View getView(Context context) throws UnsupportedOperationException;
 
     public String getId() {
         return mId;
     }
 
     public Object getValue() {
         return null;
     }