Bug 1364025 - Add Unscopable to Document.fullscreen. r=bz
☠☠ backed out by a41cadccb3ae ☠ ☠
authorXidorn Quan <me@upsuper.org>
Tue, 13 Feb 2018 11:25:12 +1100
changeset 759100 8f43644be461fc85d12226b6d35cb078cb5c4b8d
parent 759099 b2b3d3364296bf705e7c8d8b24e24dc78f01ddb0
child 759101 d2a26faa304293e281cf1745e468ebf3026ca3ba
push id100272
push userrwood@mozilla.com
push dateFri, 23 Feb 2018 18:27:33 +0000
reviewersbz
bugs1364025
milestone60.0a1
Bug 1364025 - Add Unscopable to Document.fullscreen. r=bz MozReview-Commit-ID: CK8pbdKeBas
dom/webidl/Document.webidl
testing/web-platform/meta/fullscreen/interfaces.html.ini
--- a/dom/webidl/Document.webidl
+++ b/dom/webidl/Document.webidl
@@ -229,17 +229,17 @@ partial interface Document {
   readonly attribute unsigned long referrerPolicy;
 
 };
 
 // https://fullscreen.spec.whatwg.org/#api
 partial interface Document {
   // Note: Per spec the 'S' in these two is lowercase, but the "Moz"
   // versions have it uppercase.
-  [LenientSetter, Func="nsDocument::IsUnprefixedFullscreenEnabled"]
+  [LenientSetter, Unscopable, Func="nsDocument::IsUnprefixedFullscreenEnabled"]
   readonly attribute boolean fullscreen;
   [BinaryName="fullscreen"]
   readonly attribute boolean mozFullScreen;
   [LenientSetter, Func="nsDocument::IsUnprefixedFullscreenEnabled", NeedsCallerType]
   readonly attribute boolean fullscreenEnabled;
   [BinaryName="fullscreenEnabled", NeedsCallerType]
   readonly attribute boolean mozFullScreenEnabled;
 
--- a/testing/web-platform/meta/fullscreen/interfaces.html.ini
+++ b/testing/web-platform/meta/fullscreen/interfaces.html.ini
@@ -1,15 +1,12 @@
 [interfaces.html]
   [Document interface: operation exitFullscreen()]
     expected: FAIL
 
-  [Unscopable handled correctly for fullscreen property on Document]
-    expected: FAIL
-
   [ShadowRoot interface: attribute fullscreenElement]
     expected: FAIL
 
   [Element interface: operation requestFullscreen()]
     expected: FAIL
 
   [Element interface: attribute onfullscreenchange]
     expected: FAIL