Bug 1390670 - Tabs tray close tab button is very small. r?jwu draft
authorNevin Chen <cnevinchen@gmail.com>
Wed, 23 Aug 2017 18:06:34 +0800
changeset 651192 8d378023da144ead56ea2423fdc88813327088b3
parent 651104 d4c54b78a2e77baa99894c3922f620c5b8d23262
child 727616 705b0b2aada79673357cdd9468b8707fcd198da1
push id75626
push userbmo:cnevinchen@gmail.com
push dateWed, 23 Aug 2017 10:07:10 +0000
reviewersjwu
bugs1390670
milestone57.0a1
Bug 1390670 - Tabs tray close tab button is very small. r?jwu MozReview-Commit-ID: LwM2G6nxT9H
mobile/android/app/src/main/res/layout-large/tabs_layout_item_view.xml
mobile/android/app/src/main/res/layout/tabs_layout_item_view.xml
--- a/mobile/android/app/src/main/res/layout-large/tabs_layout_item_view.xml
+++ b/mobile/android/app/src/main/res/layout-large/tabs_layout_item_view.xml
@@ -36,18 +36,18 @@
                android:paddingLeft="0dp"
                android:paddingStart="0dp"
                android:drawablePadding="6dp"/>
 
         <!-- Use of baselineAlignBottom only supported from API 11+ - if this needs to work on lower API versions
              we'll need to override getBaseLine() and return image height, but we assume this won't happen -->
         <ImageView android:id="@+id/close"
                      style="@style/TabsItemClose"
-                     android:layout_width="wrap_content"
-                     android:layout_height="wrap_content"
+                     android:layout_width="24dp"
+                     android:layout_height="24dp"
                      android:scaleType="center"
                      android:baselineAlignBottom="true"
                      android:background="@android:color/transparent"
                      android:contentDescription="@string/close_tab"
                      android:src="@drawable/tab_item_close_button"
                      android:duplicateParentState="true"/>
 
     </LinearLayout>
--- a/mobile/android/app/src/main/res/layout/tabs_layout_item_view.xml
+++ b/mobile/android/app/src/main/res/layout/tabs_layout_item_view.xml
@@ -18,17 +18,17 @@
                   android:duplicateParentState="true"
                   android:paddingLeft="@dimen/tab_highlight_stroke_width"
                   android:paddingRight="@dimen/tab_highlight_stroke_width"
                   android:paddingBottom="@dimen/tab_highlight_stroke_width">
 
        <org.mozilla.gecko.widget.FadedSingleColorTextView
                android:id="@+id/title"
                android:layout_width="0dip"
-               android:layout_height="wrap_content"
+               android:layout_height="match_parent"
                android:layout_weight="1.0"
                style="@style/TabLayoutItemTextAppearance"
                android:textSize="14sp"
                android:textColor="@color/tab_item_title"
                android:singleLine="true"
                android:duplicateParentState="true"
                gecko:fadeWidth="15dp"
                android:paddingRight="5dp"
@@ -36,18 +36,18 @@
                android:paddingLeft="0dp"
                android:paddingStart="0dp"
                android:drawablePadding="6dp"/>
 
         <!-- Use of baselineAlignBottom only supported from API 11+ - if this needs to work on lower API versions
              we'll need to override getBaseLine() and return image height, but we assume this won't happen -->
         <ImageView android:id="@+id/close"
                      style="@style/TabsItemClose"
-                     android:layout_width="wrap_content"
-                     android:layout_height="wrap_content"
+                     android:layout_width="24dp"
+                     android:layout_height="24dp"
                      android:scaleType="center"
                      android:baselineAlignBottom="true"
                      android:background="@android:color/transparent"
                      android:contentDescription="@string/close_tab"
                      android:src="@drawable/tab_item_close_button"
                      android:duplicateParentState="true"/>
 
     </LinearLayout>