Bug 1444404 - Use default (true) value for browser.newtabpage.enabled for testing. r=jmaher draft
authorEd Lee <edilee@mozilla.com>
Fri, 09 Mar 2018 10:47:10 -0800
changeset 765509 8aee22421fdcd8cc8a754ad5abe01ce52cbd85b0
parent 764767 d55b703721d234cc5730d3e12e735a03252baade
push id102097
push userbmo:edilee@mozilla.com
push dateFri, 09 Mar 2018 21:12:26 +0000
reviewersjmaher
bugs1444404, 1383599, 1444498
milestone60.0a1
Bug 1444404 - Use default (true) value for browser.newtabpage.enabled for testing. r=jmaher Before bug 1383599, the pref had effectively been always true as about:newtab always just loaded activity stream. Switching the test pref to be true matches the old behavior to fix the AWSY regression to later decide what this pref should be for testing in bug 1444498. MozReview-Commit-ID: Af9v2rgUZdl
testing/geckodriver/src/prefs.rs
testing/marionette/client/marionette_driver/geckoinstance.py
testing/marionette/components/marionette.js
--- a/testing/geckodriver/src/prefs.rs
+++ b/testing/geckodriver/src/prefs.rs
@@ -1,12 +1,12 @@
 use mozprofile::preferences::Pref;
 
 lazy_static! {
-    pub static ref DEFAULT: [(&'static str, Pref); 79] = [
+    pub static ref DEFAULT: [(&'static str, Pref); 78] = [
         // Disable automatic downloading of new releases
         ("app.update.auto", Pref::new(false)),
 
         // Disable automatically upgrading Firefox
         ("app.update.enabled", Pref::new(false)),
 
         // Increase the APZ content response timeout in tests to 1
         // minute.  This is to accommodate the fact that test environments
@@ -25,19 +25,16 @@ lazy_static! {
         // Indicate that the download panel has been shown once so
         // that whichever download test runs first does not show the popup
         // inconsistently
         ("browser.download.panel.shown", Pref::new(true)),
 
         // Implicitly accept license
         ("browser.EULA.override", Pref::new(true)),
 
-        // use about:blank as new tab page
-        ("browser.newtabpage.enabled", Pref::new(false)),
-
         // Never start the browser in offline mode
         ("browser.offline", Pref::new(false)),
 
         // Background thumbnails in particular cause grief, and disabling
         // thumbnails in general cannot hurt
         ("browser.pagethumbnails.capturing_disabled", Pref::new(true)),
 
         // Avoid performing Reader Mode intros during tests
--- a/testing/marionette/client/marionette_driver/geckoinstance.py
+++ b/testing/marionette/client/marionette_driver/geckoinstance.py
@@ -492,19 +492,16 @@ class DesktopInstance(GeckoInstance):
 
         # Indicate that the download panel has been shown once so that whichever
         # download test runs first doesn"t show the popup inconsistently
         "browser.download.panel.shown": True,
 
         # Do not show the EULA notification which can interfer with tests
         "browser.EULA.override": True,
 
-        # Turn off about:newtab and make use of about:blank instead for new opened tabs
-        "browser.newtabpage.enabled": False,
-
         # Background thumbnails in particular cause grief, and disabling thumbnails
         # in general can"t hurt - we re-enable them when tests need them
         "browser.pagethumbnails.capturing_disabled": True,
 
         # Disable safebrowsing components
         "browser.safebrowsing.blockedURIs.enabled": False,
         "browser.safebrowsing.downloads.enabled": False,
         "browser.safebrowsing.passwords.enabled": False,
--- a/testing/marionette/components/marionette.js
+++ b/testing/marionette/components/marionette.js
@@ -81,23 +81,16 @@ const RECOMMENDED_PREFS = new Map([
   ["browser.download.panel.shown", true],
 
   // Do not show the EULA notification.
   //
   // This should also be set in the profile prior to starting Firefox,
   // as it is picked up at runtime.
   ["browser.EULA.override", true],
 
-  // Turn off about:newtab and make use of about:blank instead for new
-  // opened tabs.
-  //
-  // This should also be set in the profile prior to starting Firefox,
-  // as it is picked up at runtime.
-  ["browser.newtabpage.enabled", false],
-
   // Never start the browser in offline mode
   //
   // This should also be set in the profile prior to starting Firefox,
   // as it is picked up at runtime.
   ["browser.offline", false],
 
   // Background thumbnails in particular cause grief, and disabling
   // thumbnails in general cannot hurt