Bug 1467803 - Turn off static ctors perf tests for ASan builds r?jmaher draft
authorIonut Goldan <igoldan@mozilla.com>
Mon, 11 Jun 2018 13:07:24 +0300
changeset 806848 7ecad0b718f94ca6cc4a852502e8db458a36f4e0
parent 806787 5839c449130e4ebe541858ccc76fdcd0cbb84419
push id112969
push userbmo:igoldan@mozilla.com
push dateTue, 12 Jun 2018 06:06:00 +0000
reviewersjmaher
bugs1467803
milestone62.0a1
Bug 1467803 - Turn off static ctors perf tests for ASan builds r?jmaher MozReview-Commit-ID: HYk1xKWTXv8
toolkit/crashreporter/tools/symbolstore.py
--- a/toolkit/crashreporter/tools/symbolstore.py
+++ b/toolkit/crashreporter/tools/symbolstore.py
@@ -628,23 +628,25 @@ class Dumper:
                     "subtests": [{
                         "name": "num_static_constructors",
                         "value": ctors,
                         "alertChangeType": "absolute",
                         "alertThreshold": 3
                     }]}
                 ]
             }
-            for opt in os.environ.get('PERFHERDER_EXTRA_OPTIONS', '').split():
+            perfherder_extra_options = os.environ.get('PERFHERDER_EXTRA_OPTIONS', '')
+            for opt in perfherder_extra_options.split():
                 for suite in perfherder_data['suites']:
                     if opt not in suite.get('extraOptions', []):
                         suite.setdefault('extraOptions', []).append(opt)
 
-            print('PERFHERDER_DATA: %s' % json.dumps(perfherder_data),
-                  file=sys.stderr)
+            if 'asan' not in perfherder_extra_options.lower():
+                print('PERFHERDER_DATA: %s' % json.dumps(perfherder_data),
+                    file=sys.stderr)
 
         elapsed = time.time() - t_start
         print('Finished processing %s in %.2fs' % (file, elapsed),
               file=sys.stderr)
 
 # Platform-specific subclasses.  For the most part, these just have
 # logic to determine what files to extract symbols from.