Bug 1276977 - remove unused variable and call r=liuche
authorAndrzej Hunt <ahunt@mozilla.com>
Thu, 02 Jun 2016 14:54:32 -0700
changeset 375187 7e530b2a462aeb163112e30c869442e2d6a54eef
parent 375186 6666bf0ccb50f6a59f2ce4f6ff5d68dd1f38b762
child 375188 451c0c62328bb53cc7b1b0bdc2b21ab75b892eb4
child 375190 5444ff8e6e20aaf6484f73b8fa696cd38ad077b3
child 375213 abdfe019ce5bc0319fad208a7d632faacc223c28
child 375344 e579bb5d12e5c2baf78f241a8c9ca06510881fc5
push id20186
push userrhelmer@mozilla.com
push dateFri, 03 Jun 2016 16:55:36 +0000
reviewersliuche
bugs1276977
milestone49.0a1
Bug 1276977 - remove unused variable and call r=liuche Apparently this code can crash despite the nullcheck, let's completely remove it since we don't use the results. MozReview-Commit-ID: CzHn8kABLYd
mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
--- a/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
+++ b/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
@@ -2308,18 +2308,16 @@ public class BrowserApp extends GeckoApp
             panelId = null;
         }
 
         final PropertyAnimator animator = new PropertyAnimator(250);
         animator.setUseHardwareLayer(false);
 
         mBrowserToolbar.startEditing(url, animator);
 
-        final boolean isUserSearchTerm = selectedTab != null &&
-                !TextUtils.isEmpty(selectedTab.getUserRequested());
         showHomePagerWithAnimator(panelId, null, animator);
 
         animator.start();
         Telemetry.startUISession(TelemetryContract.Session.AWESOMESCREEN);
     }
 
     private void commitEditingMode() {
         if (!mBrowserToolbar.isEditing()) {