Bug 1460882 - Disable SANDBOX_EXPORTS for the MinGW Build. r=bobowen, a=jcristau
☠☠ backed out by 035ad5ecd97e ☠ ☠
authorTom Ritter <tom@mozilla.com>
Fri, 11 May 2018 08:16:13 -0500
changeset 802202 79910289a1f331463d661f484c354eb0d90eb9cf
parent 802201 943f08e5009a902e613c2f112f56d249332b72ce
child 802203 5962d597aa946c73d7047337882dad4890b19c52
push id111850
push userbmo:tom@mozilla.com
push dateThu, 31 May 2018 16:41:37 +0000
reviewersbobowen, jcristau
bugs1460882
milestone60.0.2
Bug 1460882 - Disable SANDBOX_EXPORTS for the MinGW Build. r=bobowen, a=jcristau MozReview-Commit-ID: 2muTxIYUx6F
security/sandbox/moz.build
old mode 100644
new mode 100755
--- a/security/sandbox/moz.build
+++ b/security/sandbox/moz.build
@@ -151,19 +151,21 @@ elif CONFIG['OS_ARCH'] == 'WINNT':
             'chromium/sandbox/win/src/service_resolver_64.cc',
         ]
     else:
         SOURCES += [
             'chromium/sandbox/win/src/resolver_32.cc',
             'chromium/sandbox/win/src/service_resolver_32.cc',
         ]
 
-    for var in ('UNICODE', '_UNICODE', 'NS_NO_XPCOM', 'SANDBOX_EXPORTS',
+    for var in ('UNICODE', '_UNICODE', 'NS_NO_XPCOM',
                 '_CRT_RAND_S', 'CHROMIUM_SANDBOX_BUILD'):
         DEFINES[var] = True
+    if CONFIG['CC_TYPE'] != 'gcc':
+        DEFINES['SANDBOX_EXPORTS'] = True
 
     LOCAL_INCLUDES += ['/security/sandbox/chromium-shim']
     LOCAL_INCLUDES += ['/security/sandbox/chromium']
     LOCAL_INCLUDES += ['/nsprpub']
 
     DisableStlWrapping()
 
     # Suppress warnings in third-party code.