Bug 1325801 - Fix intermittent failure staging cppunittests. draft
authorChris Manchester <cmanchester@mozilla.com>
Fri, 06 Jan 2017 15:41:22 -0800
changeset 457169 73cc53ef4ffff5eab83a8da5c552a7c81e53fa74
parent 457090 0d823cf54df53e0cea75a74adebace956bd333d8
child 541416 6c3e15acec92e9b28e5431741a72cdcb055c2ea1
push id40704
push usercmanchester@mozilla.com
push dateSat, 07 Jan 2017 00:19:13 +0000
Bug 1325801 - Fix intermittent failure staging cppunittests. Dumping symbols can interfere with staging cppunittests in case calling objcopy from the symbol dumping script coincides exactly with calling objcopy when staging cppunittests when the two are run in parallel. This patch prevents symbol dumping from happening while tests are being packaged. MozReview-Commit-ID: Hgi1zyIZE7K
--- a/build/moz-automation.mk
+++ b/build/moz-automation.mk
@@ -73,16 +73,21 @@ automation/pretty-l10n-check: automation
 automation/upload: automation/installer
 automation/upload: automation/package
 automation/upload: automation/package-tests
 automation/upload: automation/buildsymbols
 automation/upload: automation/update-packaging
 automation/upload: automation/sdk
+# buildsymbols will modify our test binaries, which can interfere with
+# packaging them. A finer-grained dependency can help performance here
+# once bug 1329020 is fixed.
+automation/pretty-package-tests: automation/buildsymbols
 # automation/{pretty-}package should depend on build (which is implicit due to
 # the way client.mk invokes automation/build), but buildsymbols changes the
 # binaries/libs, and that's what we package/test.
 automation/pretty-package: automation/buildsymbols
 # The installer, sdk and packager all run stage-package, and may conflict
 # with each other.
 automation/installer: automation/package