Bug 1343442 - Allow MediaDecodeError/Warning user notifications in Nightly - r?jya draft
authorGerald Squelart <gsquelart@mozilla.com>
Fri, 24 Mar 2017 16:37:45 +1100
changeset 560833 738694f4e574d57c37f4c2f3cd31ad5e11d3348c
parent 560832 7522590fa8fad5f630d1c8b3c5c73baad8cf10b6
child 560834 f61ae9e102c78c81e61b9b20692bea809fcb6511
push id53551
push usergsquelart@mozilla.com
push dateTue, 11 Apr 2017 23:47:44 +0000
Bug 1343442 - Allow MediaDecodeError/Warning user notifications in Nightly - r?jya We want the new MediaDecodeError messages to be forwarded to the front-end in browser-media.js (even though they won't be handled just yet; an upcoming patch will add the handling code). This is limited to Nightly for now, like the "Report Site Issues" button, because we forward URLs to webcompat.com (at the user's request). And MediaDecodeWarning was not added, as it may cause too much annoyance, but it is available for testers to get more diagnostics information if needed. MozReview-Commit-ID: HPDpA1mg4HX
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -380,17 +380,21 @@ pref("media.apple.mp4.enabled", true);
 // media.gmp.storage.version.observed, and if the versions don't match,
 // we clear storage and set media.gmp.storage.version.observed=expected.
 // This provides a mechanism to clear GMP storage when non-compatible
 // changes are made.
 pref("media.gmp.storage.version.expected", 1);
 // Filter what triggers user notifications.
 // See DecoderDoctorDocumentWatcher::ReportAnalysis for details.
+pref("media.decoder-doctor.notifications-allowed", "MediaWMFNeeded,MediaWidevineNoWMF,MediaCannotInitializePulseAudio,MediaCannotPlayNoDecoders,MediaUnsupportedLibavcodec,MediaDecodeError");
 pref("media.decoder-doctor.notifications-allowed", "MediaWMFNeeded,MediaWidevineNoWMF,MediaCannotInitializePulseAudio,MediaCannotPlayNoDecoders,MediaUnsupportedLibavcodec");
 // Whether we report partial failures.
 pref("media.decoder-doctor.verbose", false);
 // Whether DD should consider WMF-disabled a WMF failure, useful for testing.
 pref("media.decoder-doctor.wmf-disabled-is-failure", false);
 // Whether to suspend decoding of videos in background tabs.
 pref("media.suspend-bkgnd-video.enabled", true);