Bug 1371676 - Improve Sync Notification Titles r=eoger draft
authorJeongkyu Kim <jeongkyu.kim@gmail.com>
Tue, 13 Jun 2017 21:26:58 +0900
changeset 594862 6fa58119de38
parent 593303 a8f8e440d627
child 633555 1e7aac263f8f
push id64173
push userbmo:jeongkyu.kim@gmail.com
push dateThu, 15 Jun 2017 15:53:23 +0000
reviewerseoger
bugs1371676
milestone56.0a1
Bug 1371676 - Improve Sync Notification Titles r=eoger MozReview-Commit-ID: 5SZJpicDuXC
browser/components/nsBrowserGlue.js
browser/locales/en-US/chrome/browser/accounts.properties
--- a/browser/components/nsBrowserGlue.js
+++ b/browser/components/nsBrowserGlue.js
@@ -2245,17 +2245,17 @@ BrowserGlue.prototype = {
         }
         // Use the page URL as the body. We strip the fragment and query to
         // reduce size, and also format it the same way that the url bar would.
         body = URIs[0].uri.replace(/[?#].*$/, "");
         if (win.gURLBar) {
           body = win.gURLBar.trimValue(body);
         }
       } else {
-        title = bundle.GetStringFromName("tabsArrivingNotification.title");
+        title = bundle.GetStringFromName("multipleTabsArrivingNotification.title");
         const allSameDevice = URIs.every(URI => URI.clientId == URIs[0].clientId);
         const unknownDevice = allSameDevice && !deviceName;
         let tabArrivingBody;
         if (unknownDevice) {
           tabArrivingBody = "unnamedTabsArrivingNotificationNoDevice.body";
         } else if (allSameDevice) {
           tabArrivingBody = "unnamedTabsArrivingNotification2.body";
         } else {
--- a/browser/locales/en-US/chrome/browser/accounts.properties
+++ b/browser/locales/en-US/chrome/browser/accounts.properties
@@ -27,35 +27,35 @@ deviceConnectedBody.noDeviceName = This 
 # LOCALIZATION NOTE (syncStartNotification.title, syncStartNotification.body)
 # These strings are used in a notification shown after Sync is connected.
 syncStartNotification.title = Sync Enabled
 # %S is brandShortName
 syncStartNotification.body2 = %S will begin syncing momentarily.
 
 # LOCALIZATION NOTE (deviceDisconnectedNotification.title, deviceDisconnectedNotification.body)
 # These strings are used in a notification shown after Sync was disconnected remotely.
-deviceDisconnectedNotification.title = Sync disconnected
+deviceDisconnectedNotification.title = Sync Disconnected
 deviceDisconnectedNotification.body = This computer has been successfully disconnected from Firefox Sync.
 
 # LOCALIZATION NOTE (sendTabToAllDevices.menuitem)
 # Displayed in the Send Tabs context menu when right clicking a tab, a page or a link.
 sendTabToAllDevices.menuitem = All Devices
 
 # LOCALIZATION NOTE (tabArrivingNotification.title, tabArrivingNotificationWithDevice.title,
-# tabsArrivingNotification.title, unnamedTabsArrivingNotification2.body,
+# multipleTabsArrivingNotification.title, unnamedTabsArrivingNotification2.body,
 # unnamedTabsArrivingNotificationMultiple2.body, unnamedTabsArrivingNotificationNoDevice.body)
 # These strings are used in a notification shown when we're opening tab(s) another device sent us to display.
 
 # LOCALIZATION NOTE (tabArrivingNotification.title, tabArrivingNotificationWithDevice.title)
 # The body for these is the URL of the tab recieved
-tabArrivingNotification.title = Tab received
+tabArrivingNotification.title = Tab Received
 # LOCALIZATION NOTE (tabArrivingNotificationWithDevice.title) %S is the device name
 tabArrivingNotificationWithDevice.title = Tab from %S
 
-tabsArrivingNotification.title = Multiple tabs received
+multipleTabsArrivingNotification.title = Tabs Received
 # LOCALIZATION NOTE (unnamedTabsArrivingNotification2.body):
 # Semi-colon list of plural forms.
 # See: http://developer.mozilla.org/en/docs/Localization_and_Plurals
 # #1 is the number of tabs received and #2 is the device name.
 unnamedTabsArrivingNotification2.body = #1 tab has arrived from #2;#1 tabs have arrived from #2
 # LOCALIZATION NOTE (unnamedTabsArrivingNotificationMultiple2.body):
 # Semi-colon list of plural forms.
 # See: http://developer.mozilla.org/en/docs/Localization_and_Plurals