Bug 1107636 - Change RelativeLayout params -> FrameLayout params. r=me
☠☠ backed out by 5f9371f97e1e ☠ ☠
authorMichael Comella <michael.l.comella@gmail.com>
Wed, 11 Nov 2015 08:58:36 -0800
changeset 308411 6e940538a1718ca8f2fba26b50dc1a44046ac916
parent 308410 9145f78bb39c3fbc447e3d0b743e46615f405ffc
child 308412 dd627c83397a2be0216a881e6a58e5f5f5675cdd
push id7470
push users.kaspari@gmail.com
push dateThu, 12 Nov 2015 12:51:02 +0000
reviewersme
bugs1107636
milestone45.0a1
Bug 1107636 - Change RelativeLayout params -> FrameLayout params. r=me Due to the import, LayoutParams was RelativeLayout.LayoutParams and it was referring to the parent container, which is now a FrameLayout.
mobile/android/base/FormAssistPopup.java
--- a/mobile/android/base/FormAssistPopup.java
+++ b/mobile/android/base/FormAssistPopup.java
@@ -1,15 +1,16 @@
 /* -*- Mode: Java; c-basic-offset: 4; tab-width: 20; indent-tabs-mode: nil; -*-
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 package org.mozilla.gecko;
 
+import android.widget.FrameLayout;
 import org.mozilla.gecko.animation.ViewHelper;
 import org.mozilla.gecko.gfx.FloatSize;
 import org.mozilla.gecko.gfx.ImmutableViewportMetrics;
 import org.mozilla.gecko.util.GeckoEventListener;
 import org.mozilla.gecko.util.ThreadUtils;
 import org.mozilla.gecko.widget.SwipeDismissListViewTouchListener;
 import org.mozilla.gecko.widget.SwipeDismissListViewTouchListener.OnDismissCallback;
 
@@ -355,17 +356,17 @@ public class FormAssistPopup extends Rel
                 if (mPopupType == PopupType.VALIDATIONMESSAGE) {
                     mValidationMessageText.setLayoutParams(sValidationTextLayoutInverted);
                     mValidationMessageArrow.setVisibility(GONE);
                     mValidationMessageArrowInverted.setVisibility(VISIBLE);
                 }
            }
         }
 
-        LayoutParams layoutParams = new LayoutParams(popupWidth, popupHeight);
+        final FrameLayout.LayoutParams layoutParams = new FrameLayout.LayoutParams(popupWidth, popupHeight);
         layoutParams.setMargins(popupLeft, popupTop, 0, 0);
         setLayoutParams(layoutParams);
         requestLayout();
 
         if (!isShown()) {
             setVisibility(VISIBLE);
             startAnimation(mAnimation);
         }