Bug 1381577 - Remove target.complete.mar from OSX l10n signing (its signed as part of repackage) and error out if an unknown platform attempts to get signed from l10n. r=kmoir draft
authorJustin Wood <Callek@gmail.com>
Tue, 18 Jul 2017 14:29:46 -0400
changeset 611736 6dbe6b8a05640930a5ba1103b89898ae3e7a9e64
parent 611735 f582ad4e11e93cb3ef331dd671fa3b30572996a5
child 611737 e2119d9036e69983bc989e78401329a6dc98db58
push id69287
push userCallek@gmail.com
push dateThu, 20 Jul 2017 01:11:37 +0000
reviewerskmoir
bugs1381577
milestone56.0a1
Bug 1381577 - Remove target.complete.mar from OSX l10n signing (its signed as part of repackage) and error out if an unknown platform attempts to get signed from l10n. r=kmoir Land date changes to support windows nightlies onto central MozReview-Commit-ID: 9lWSEbQznyr
taskcluster/taskgraph/transforms/nightly_l10n_signing.py
--- a/taskcluster/taskgraph/transforms/nightly_l10n_signing.py
+++ b/taskcluster/taskgraph/transforms/nightly_l10n_signing.py
@@ -26,34 +26,34 @@ def make_signing_description(config, job
             job_specs = [
                 {
                     'artifacts': ['public/build/{locale}/target.apk'],
                     'format': 'jar',
                 },
             ]
         elif 'macosx' in dep_platform:
             job_specs = [
-                 {
+                {
                     'artifacts': ['public/build/{locale}/target.dmg'],
                     'format': 'macapp',
-                 }, {
-                    'artifacts': ['public/build/{locale}/target.complete.mar'],
-                    'format': 'mar',
-                 }
+                }
             ]
-        else:
+        elif 'linux' in dep_platform:
             job_specs = [
                 {
                     'artifacts': ['public/build/{locale}/target.tar.bz2'],
                     'format': 'gpg',
                 }, {
                     'artifacts': ['public/build/{locale}/target.complete.mar'],
                     'format': 'mar',
                 }
             ]
+        else:
+            raise Exception("Platform not implemented for signing")
+
         upstream_artifacts = []
         for spec in job_specs:
             fmt = spec['format']
             upstream_artifacts.append({
                 "taskId": {"task-reference": "<unsigned-repack>"},
                 "taskType": "l10n",
                 # Set paths based on artifacts in the specs (above) one per
                 # locale present in the chunk this is signing stuff for.