Bug 1419128 - Don't use mutable default argument value; r?build draft
authorGregory Szorc <gps@mozilla.com>
Mon, 20 Nov 2017 14:14:56 -0800
changeset 700807 6b6fb08db8c46a4fd75822326543fb63a903daea
parent 700806 c241240e313b6c128b95522afae64251e6a23144
child 700808 c92199f27944f0871b72595b18f49cdcf0738640
push id89984
push userbmo:gps@mozilla.com
push dateMon, 20 Nov 2017 23:14:50 +0000
reviewersbuild
bugs1419128
milestone59.0a1
Bug 1419128 - Don't use mutable default argument value; r?build We always passed this argument in so this change doesn't fix any bugs. I just didn't like the code smell.
build/compare-mozconfig/compare-mozconfigs.py
--- a/build/compare-mozconfig/compare-mozconfigs.py
+++ b/build/compare-mozconfig/compare-mozconfigs.py
@@ -37,17 +37,17 @@ def make_hg_url(hgHost, repoPath, protoc
                          filename]])
 
 def readConfig(configfile):
     c = {}
     execfile(configfile, c)
     return c['whitelist']
 
 def verify_mozconfigs(mozconfig_pair, nightly_mozconfig_pair, platform,
-                      mozconfigWhitelist={}):
+                      mozconfigWhitelist):
     """Compares mozconfig to nightly_mozconfig and compare to an optional
     whitelist of known differences. mozconfig_pair and nightly_mozconfig_pair
     are pairs containing the mozconfig's identifier and the list of lines in
     the mozconfig."""
 
     # unpack the pairs to get the names, the names are just for
     # identifying the mozconfigs when logging the error messages
     mozconfig_name, mozconfig_lines = mozconfig_pair