Bug 1342946 - Fix wrong MOZ_ASSERT(true) in places/Database.cpp. r=standard8
authorMarco Bonardo <mbonardo@mozilla.com>
Tue, 28 Feb 2017 13:53:16 +0100
changeset 490518 69c6da6207542917c7e0a50caf614ac1f57c6314
parent 490517 86de81c342fd5844644f354f3b7768092698a701
child 490519 f0b24983d137386c8b3b443d3866d7fa7077fa43
push id47118
push userbmo:ttromey@mozilla.com
push dateTue, 28 Feb 2017 17:09:36 +0000
reviewersstandard8
bugs1342946
milestone54.0a1
Bug 1342946 - Fix wrong MOZ_ASSERT(true) in places/Database.cpp. r=standard8 MozReview-Commit-ID: 1gkIRqN1yYE
toolkit/components/places/Database.cpp
--- a/toolkit/components/places/Database.cpp
+++ b/toolkit/components/places/Database.cpp
@@ -242,18 +242,17 @@ SetJournalMode(nsCOMPtr<mozIStorageConne
       return JOURNAL_TRUNCATE;
     }
     if (journalMode.EqualsLiteral("memory")) {
       return JOURNAL_MEMORY;
     }
     if (journalMode.EqualsLiteral("wal")) {
       return JOURNAL_WAL;
     }
-    // This is an unknown journal.
-    MOZ_ASSERT(true);
+    MOZ_ASSERT(false, "Got an unknown journal mode.");
   }
 
   return JOURNAL_DELETE;
 }
 
 nsresult
 CreateRoot(nsCOMPtr<mozIStorageConnection>& aDBConn,
            const nsCString& aRootName, const nsCString& aGuid,