Backed out changeset b2f02ad2c82b (bug 1363361) for frequently failing browser_appmenu_reflows.js on OS X. r=backout a=backout
authorSebastian Hengst <archaeopteryx@coole-files.de>
Thu, 20 Jul 2017 13:23:53 +0200
changeset 612171 68046a58f82913eb7804e4796ec981f6f8ea490e
parent 612170 c37e118e823b15e9569acf3b51d15f584ab1e81d
child 612172 dbf0dc9fac05903ba8174ae1da554a47f6c1586f
child 612179 ed36b21608f56389db161ec50dcdb612ff531260
child 612180 64f6154bab661c043f880fa91242218850acec98
child 612181 d5a8a8c0e949337ed1f06ae4a43c22be582ea8ca
child 612182 db1d907c30a94745b060b97158f5135b01ba5759
child 612202 463a51db290908a5e5e53e71670f80ef5c9ec68c
child 612206 c80e95ad78cd2a3afb644b69aba2607fe3c56a18
child 612208 d86a2f73833b8d4e6b29dcabcf283fe1dde68261
child 612232 d9eb2b3aa024cf378ac7b50d8d8ff335ae3355da
child 612237 f8dd97419feee2dd014e79aaea2f3aec8213a44a
child 612244 84f072290811909edb1d2f4b31c238b6643f4d0a
child 612247 e7c7dec14413fca2baab704b91da71b0d22db9f7
child 612249 e1a1effc93627b5c3f18265f06685f6316b7ab4d
child 612251 ce4d7ff3ca8b1640db7a6ce43a62177ed158e5fb
child 612255 de22d4444e76e5b8cdb80e772776d283210eaaf2
child 612259 1fd5dc08db03e253f0cc7a4e4edd952b5cd244ee
child 612260 f73ca13910390fc26d68b0f4b8f399fc37b34771
child 612306 17a303dae9ec79514fd79dff5eb498d8d0d1ba42
child 612307 c17e6464ec87fd191923d80dc5e43e453b8211a9
child 612309 bb2cc10f2bdaa607951b298d023f775c92d4a298
child 612310 9b520a18a8c8a4c056cbfa21a5e4b2a9444f78cc
child 612312 2c200747a5e9cd83527f89e877e4467a96d2850d
child 612314 cf759b6fb0af73de5108ea664281fec8057463a7
child 612320 aeb12be8900e7f11a8ccf3b04510b102edde46ec
child 612458 82bfed4f5f556c3eb6e1f34fb8d739075b9f3cd7
child 612466 5db462576a4152dfd865030d63280191651999b3
child 612471 9f0f269bbae2c49b1ae2eb3139fcbcc610fa72ca
child 612472 c7979cb3737fe50193aea312e39fdfa9d88b4dbf
child 612473 be203540e762615bef304374b9df5f1ca3882171
child 612475 1dfb5879326212c3fb94aab8a892a7af69a1f45d
child 612530 58fa203e15cb85a76210fb55a759e6369158a408
child 612535 06cc6266b3e1edfbac3bc31dfc529faddcf46f5e
child 612536 59870c4bae3664aebf448acee439b918190591dc
child 612558 b53f5c9fe87af7910a3e09f2b681ed51800324f8
child 612569 1fb5509fa452e257826c7a1882d3f52024c75a69
child 613058 5beff29c0ba51aede53a570acd81fb3aeacf5230
child 613112 4031a076fc03f7558fa265176240bae64880f600
child 615288 2687c66da4ce79b99029c42c724a7f62daed7e1c
push id69413
push userjodvarko@mozilla.com
push dateThu, 20 Jul 2017 12:55:18 +0000
reviewersbackout, backout
bugs1363361
milestone56.0a1
backs outb2f02ad2c82b2d5b0088aa20c7caaa3bd203ed53
Backed out changeset b2f02ad2c82b (bug 1363361) for frequently failing browser_appmenu_reflows.js on OS X. r=backout a=backout MozReview-Commit-ID: 5wPiUAKmDhi
dom/base/nsDOMWindowUtils.cpp
dom/interfaces/base/nsIDOMWindowUtils.idl
--- a/dom/base/nsDOMWindowUtils.cpp
+++ b/dom/base/nsDOMWindowUtils.cpp
@@ -4437,36 +4437,16 @@ nsDOMWindowUtils::GetDirectionFromText(c
     case eDir_Auto:
       MOZ_ASSERT_UNREACHABLE("GetDirectionFromText should never return this value");
       return NS_ERROR_FAILURE;
   }
   return NS_OK;
 }
 
 NS_IMETHODIMP
-nsDOMWindowUtils::EnsureDirtyRootFrame()
-{
-  nsIDocument* doc = GetDocument();
-  nsIPresShell* presShell = doc ? doc->GetShell() : nullptr;
-
-  if (!presShell) {
-    return NS_ERROR_FAILURE;
-  }
-
-  nsIFrame* frame = presShell->GetRootFrame();
-  if (!frame) {
-    return NS_ERROR_FAILURE;
-  }
-
-  presShell->FrameNeedsReflow(frame, nsIPresShell::eStyleChange,
-                              NS_FRAME_IS_DIRTY);
-  return NS_OK;
-}
-
-NS_IMETHODIMP
 nsDOMWindowUtils::GetIsStyledByServo(bool* aStyledByServo)
 {
   nsIDocument* doc = GetDocument();
   *aStyledByServo = doc && doc->IsStyledByServo();
   return NS_OK;
 }
 
 NS_INTERFACE_MAP_BEGIN(nsTranslationNodeList)
--- a/dom/interfaces/base/nsIDOMWindowUtils.idl
+++ b/dom/interfaces/base/nsIDOMWindowUtils.idl
@@ -2019,24 +2019,16 @@ interface nsIDOMWindowUtils : nsISupport
    *
    * @param aString the string to retrieve the direction for.
    * @return one of DIRECTION_LTR, DIRECTION_RTL or DIRECTION_NOT_SET depending
    *         on the first-strong character found in the string.
    */
   long getDirectionFromText(in AString aString);
 
   /**
-   * Calls FrameNeedsReflow on that root frame so that a layout flush
-   * will be necessary.
-   *
-   * This should only be used for testing.
-   */
-  void ensureDirtyRootFrame();
-
-  /**
    * Whether the current document is styled by Servo's style engine.
    *
    * This calls nsIDocument::IsStyledByServo().
    */
   readonly attribute boolean isStyledByServo;
 
   // These consts are only for testing purposes.
   const long DEFAULT_MOUSE_POINTER_ID = 0;