Correctly reparent split absolute frame list draft
authorNeerja Pancholi <npancholi@mozilla.com>
Tue, 07 Nov 2017 16:52:46 -0800
changeset 698709 6651d9ef742454d75abc22bcb596a19d0d4a98e9
parent 698708 95c0bd606380c94aac4dcc6fc4bc159f669a17ec
child 698710 bf74488c60d31cf4a948252a9683c719bb77ff24
push id89334
push userbmo:npancholi@mozilla.com
push dateThu, 16 Nov 2017 00:39:30 +0000
milestone59.0a1
Correctly reparent split absolute frame list MozReview-Commit-ID: 6XXWQuKZTyu
layout/base/nsCSSFrameConstructor.cpp
--- a/layout/base/nsCSSFrameConstructor.cpp
+++ b/layout/base/nsCSSFrameConstructor.cpp
@@ -12585,19 +12585,18 @@ nsCSSFrameConstructor::SplitAbsoluteList
         // into the splitAbsoluteList
         nsIFrame* parent = placeholder->GetParent();
         while (parent && parent != aSplitFrame) {
           parent = parent->GetParent();
         }
         if (parent) {
           nsIFrame* nextAbsoluteFrame = currAbsoluteFrame->GetNextSibling();
           aOriginalAbsoluteList.RemoveFrame(currAbsoluteFrame);
-          
-          // xxxNeerja - Do I need to reparent these absolute frames??
-          aSplitAbsoluteList.AppendFrame(nullptr, currAbsoluteFrame);
+
+          aSplitAbsoluteList.AppendFrame(aSplitFrame, currAbsoluteFrame);
           currAbsoluteFrame = nextAbsoluteFrame;
         }
       } else {
         NS_WARNING("An OOF exists with a null placeholder!");
       }
     }
 }