Bug 1265342 Part N-1: Update shape-outside ellipse tests to correct invalid use of only one radius parameter. draft
authorBrad Werth <bwerth@mozilla.com>
Wed, 14 Mar 2018 14:21:12 -0700
changeset 769677 64ae3a897b0686ce34968e84e788b9667614fd73
parent 769676 f0726e4fe33a650cb93791c8d6ef8881d58bf004
child 769678 68d17b6183f9a85fa9036f728bffcc0b5b51f50b
push id103205
push userbwerth@mozilla.com
push dateMon, 19 Mar 2018 23:31:42 +0000
bugs1265342
milestone61.0a1
Bug 1265342 Part N-1: Update shape-outside ellipse tests to correct invalid use of only one radius parameter. https://www.w3.org/TR/css-shapes-1/#funcdef-ellipse states that the grammar for ellipse is: ellipse() = ellipse( [<shape-radius>{2}]? [at <position>]? ) This permits either 0 or 2 shape-radius tokens, but not 1. These two tests use 1 shape-radius token and do not parse correctly. https://www.w3.org/TR/css-shapes-1/#typedef-shape-radius states that omitted shape-radius values default to closest-side. This change updates these two tests to add the closest-side value for the missing shape-radius tokens. MozReview-Commit-ID: 9UKxJel1b50
testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-015.html
testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-017.html
--- a/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-015.html
+++ b/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-015.html
@@ -29,17 +29,17 @@
     }
     #test-shape {
         float: left;
         width: 140px;
         height: 140px;
         margin: 10px;
         padding: 10px;
         border: 10px solid transparent;
-        shape-outside: padding-box ellipse(closest-side at 75px 80px);
+        shape-outside: padding-box ellipse(closest-side closest-side at 75px 80px);
     }
     #line {
         position: absolute;
         top: 0px;
         left: 168px;
         width: 2px;
         height: 200px;
         border-left: 2px solid blue;
--- a/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-017.html
+++ b/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-017.html
@@ -31,17 +31,17 @@
     #test-shape {
         float: left;
         width: 130px;
         height: 130px;
         margin: 10px;
         padding: 10px;
         border: 10px solid transparent;
         shape-margin: 10px;
-        shape-outside: content-box ellipse(farthest-side);
+        shape-outside: content-box ellipse(farthest-side closest-side);
     }
     #line {
         position: absolute;
         top: 0px;
         left: 168px;
         width: 2px;
         height: 200px;
         border-left: 2px solid blue;