Bug 1222747 - fix width of forward button on devedition theme by making it a CSS variable, r?dao
--- a/browser/themes/linux/browser.css
+++ b/browser/themes/linux/browser.css
@@ -11,20 +11,21 @@
@namespace svg url("http://www.w3.org/2000/svg");
%include ../shared/browser.inc
%include linuxShared.inc
%filter substitution
%define forwardTransitionLength 150ms
%define conditionalForwardWithUrlbar window:not([chromehidden~="toolbar"]) #urlbar-wrapper
-%define conditionalForwardWithUrlbarWidth 31
:root {
--backbutton-urlbar-overlap: 6px;
+ /* icon width + border + horizontal padding (includes the overlap from backbutton-urlbar-overlap) */
+ --forwardbutton-width: 31px;
--toolbarbutton-hover-background: rgba(255,255,255,.5) linear-gradient(rgba(255,255,255,.5), transparent);
--toolbarbutton-hover-bordercolor: rgba(0,0,0,.25);
--toolbarbutton-hover-boxshadow: none;
--toolbarbutton-active-background: rgba(154,154,154,.5) linear-gradient(rgba(255,255,255,.7), rgba(255,255,255,.4));
--toolbarbutton-active-bordercolor: rgba(0,0,0,.3);
--toolbarbutton-active-boxshadow: 0 1px 1px rgba(0,0,0,.1) inset, 0 0 1px rgba(0,0,0,.3) inset;
@@ -738,35 +739,35 @@ menuitem:not([type]):not(.menuitem-toolt
padding: 0;
}
#forward-button > .toolbarbutton-icon {
padding-left: calc(var(--backbutton-urlbar-overlap) + 3px);
padding-right: 3px;
border-left-style: none;
border-radius: 0;
- max-width: @conditionalForwardWithUrlbarWidth@px;
+ max-width: var(--forwardbutton-width);
}
@conditionalForwardWithUrlbar@:not([switchingtabs]) > #forward-button {
transition: margin-left @forwardTransitionLength@ ease-out;
}
@conditionalForwardWithUrlbar@ > #forward-button[disabled] {
- margin-left: -@conditionalForwardWithUrlbarWidth@px;
+ margin-left: calc(0px - var(--forwardbutton-width));
}
@conditionalForwardWithUrlbar@:hover:not([switchingtabs]) > #forward-button[disabled] {
/* delay the hiding of the forward button when hovered to avoid accidental clicks on the url bar */
transition-delay: 100s;
}
@conditionalForwardWithUrlbar@:not(:hover) > #forward-button[disabled] {
/* when not hovered anymore, trigger a new transition to hide the forward button immediately */
- margin-left: -@conditionalForwardWithUrlbarWidth@.01px;
+ margin-left: calc(-0.01px - var(--forwardbutton-width));
}
/* undo close tab menu item */
#alltabs_undoCloseTab {
list-style-image: url(chrome://browser/skin/undoCloseTab.png);
}
.unified-nav-back[_moz-menuactive] {
--- a/browser/themes/linux/devedition.css
+++ b/browser/themes/linux/devedition.css
@@ -1,14 +1,18 @@
% This Source Code Form is subject to the terms of the Mozilla Public
% License, v. 2.0. If a copy of the MPL was not distributed with this
% file, You can obtain one at http://mozilla.org/MPL/2.0/.
%include ../shared/devedition.inc.css
+:root {
+ --forwardbutton-width: 29px;
+}
+
:root[devtoolstheme="dark"] .findbar-closebutton:not(:hover),
:root[devtoolstheme="dark"] #sidebar-header > .close-icon:not(:hover),
.tab-close-button[visuallyselected]:not(:hover) {
background-image: -moz-image-rect(url("chrome://global/skin/icons/close.svg"), 0, 80, 16, 64);
}
/* The menubar and tabs toolbar should match the devedition theme */
#TabsToolbar,
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -3,29 +3,30 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
@import url("chrome://global/skin/");
%include shared.inc
%filter substitution
%define forwardTransitionLength 150ms
%define conditionalForwardWithUrlbar window:not([chromehidden~="toolbar"]) #urlbar-wrapper
-%define conditionalForwardWithUrlbarWidth 32
%define toolbarButtonPressed :hover:active:not([disabled="true"]):not([cui-areatype="menu-panel"])
%define windowButtonMarginTop 11px
@namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
@namespace html url("http://www.w3.org/1999/xhtml");
@namespace svg url("http://www.w3.org/2000/svg");
:root {
--space-above-tabbar: 9px;
--tabs-toolbar-color: #333;
--backbutton-urlbar-overlap: 6px;
+ /* icon width + border + horizontal padding (includes the overlap from backbutton-urlbar-overlap) */
+ --forwardbutton-width: 32px;
--toolbarbutton-hover-background: hsla(0,0%,100%,.1) linear-gradient(hsla(0,0%,100%,.3), hsla(0,0%,100%,.1)) padding-box;
--toolbarbutton-hover-bordercolor: hsla(0,0%,0%,.2);
--toolbarbutton-hover-boxshadow: 0 1px 0 hsla(0,0%,100%,.5),
0 1px 0 hsla(0,0%,100%,.5) inset;
--toolbarbutton-active-background: hsla(0,0%,0%,.02) linear-gradient(hsla(0,0%,0%,.12), transparent) border-box;
--toolbarbutton-active-bordercolor: hsla(0,0%,0%,.3);
@@ -1374,27 +1375,27 @@ toolbar .toolbarbutton-1 > .toolbarbutto
}
}
@conditionalForwardWithUrlbar@:not([switchingtabs]) > #forward-button {
transition: margin-left @forwardTransitionLength@ ease-out;
}
@conditionalForwardWithUrlbar@ > #forward-button[disabled] {
- margin-left: -@conditionalForwardWithUrlbarWidth@px;
+ margin-left: calc(0px - var(--forwardbutton-width));
}
@conditionalForwardWithUrlbar@:hover:not([switchingtabs]) > #forward-button[disabled] {
/* delay the hiding of the forward button when hovered to avoid accidental clicks on the url bar */
transition-delay: 100s;
}
@conditionalForwardWithUrlbar@:not(:hover) > #forward-button[disabled] {
/* when not hovered anymore, trigger a new transition to hide the forward button immediately */
- margin-left: -@conditionalForwardWithUrlbarWidth@.01px;
+ margin-left: calc(-0.01px - var(--forwardbutton-width));
}
.unified-nav-back[_moz-menuactive]:-moz-locale-dir(ltr),
.unified-nav-forward[_moz-menuactive]:-moz-locale-dir(rtl) {
list-style-image: url("chrome://browser/skin/menu-back.png") !important;
}
.unified-nav-forward[_moz-menuactive]:-moz-locale-dir(ltr),
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -15,16 +15,19 @@
%define forwardTransitionLength 150ms
%define conditionalForwardWithUrlbar window:not([chromehidden~="toolbar"]) #urlbar-wrapper
:root {
--space-above-tabbar: 15px;
--backbutton-urlbar-overlap: 6px;
+ /* icon width + border + horizontal padding (includes the overlap from backbutton-urlbar-overlap) */
+ --forwardbutton-width: 31px;
+
--toolbarbutton-vertical-inner-padding: 2px;
--toolbarbutton-vertical-outer-padding: 8px;
--toolbarbutton-hover-background: rgba(0,0,0,.1);
--toolbarbutton-hover-bordercolor: rgba(0,0,0,.2);
--toolbarbutton-hover-boxshadow: none;
--toolbarbutton-active-background: rgba(0,0,0,.15);
@@ -934,37 +937,35 @@ toolbar[brighttext] .toolbarbutton-1 > .
margin-top: 1px !important;
}
#forward-button > .toolbarbutton-icon {
border-left-style: none !important;
border-radius: 0 !important;
padding-left: calc(var(--backbutton-urlbar-overlap) + 3px) !important;
padding-right: 3px !important;
-% icon width + border + horizontal padding without --backbutton-urlbar-overlap
-%define forwardButtonWidth 25
- max-width: calc(@forwardButtonWidth@px + var(--backbutton-urlbar-overlap)) !important;
+ max-width: var(--forwardbutton-width) !important;
}
@conditionalForwardWithUrlbar@:not([switchingtabs]) > #forward-button {
transition: margin-left @forwardTransitionLength@ ease-out;
}
@conditionalForwardWithUrlbar@ > #forward-button[disabled] {
- margin-left: calc(-@forwardButtonWidth@px - var(--backbutton-urlbar-overlap));
+ margin-left: calc(0px - var(--forwardbutton-width));
}
@conditionalForwardWithUrlbar@:hover:not([switchingtabs]) > #forward-button[disabled] {
/* delay the hiding of the forward button when hovered to avoid accidental clicks on the url bar */
transition-delay: 100s;
}
@conditionalForwardWithUrlbar@:not(:hover) > #forward-button[disabled] {
/* when not hovered anymore, trigger a new transition to hide the forward button immediately */
- margin-left: calc(-@forwardButtonWidth@.01px - var(--backbutton-urlbar-overlap));
+ margin-left: calc(-0.01px - var(--forwardbutton-width));
}
#back-button {
padding-top: 3px !important;
padding-bottom: 3px !important;
-moz-padding-start: 5px !important;
-moz-padding-end: 0 !important;
position: relative !important;
--- a/browser/themes/windows/devedition.css
+++ b/browser/themes/windows/devedition.css
@@ -1,14 +1,18 @@
% This Source Code Form is subject to the terms of the Mozilla Public
% License, v. 2.0. If a copy of the MPL was not distributed with this
% file, You can obtain one at http://mozilla.org/MPL/2.0/.
%include ../shared/devedition.inc.css
+:root {
+ --forwardbutton-width: 29px;
+}
+
:root[devtoolstheme="dark"],
:root[devtoolstheme="light"] {
/* Matches the #browser-border-start, #browser-border-end color */
--chrome-nav-bar-separator-color: rgba(10, 31, 51, 0.35);
}
/* The window background is white due to no accentcolor in the lightweight
theme. It can't be changed to transparent when there is no compositor