Bug 1421380 - Enable gfx.webrender.hit-test by default. r=jrmuizel
authorKartikaya Gupta <kgupta@mozilla.com>
Mon, 29 Jan 2018 16:35:10 -0500
changeset 749092 5fc179e245d51289f1f7bcaba0c29189d3336fbf
parent 749091 c182e492a2e7f1477851bcd5bca8e97ef235a3d7
child 749120 217fc14405e78d47fb60888b9f3d0527d0c2709a
child 749165 158b5cd07b2ffb45a871588d299c9e26ba7355f3
child 749289 30c24fbfc8602dfb87d63ea5484a385016479a56
push id97316
push userbmo:continuation@gmail.com
push dateTue, 30 Jan 2018 22:53:01 +0000
reviewersjrmuizel
bugs1421380
milestone60.0a1
Bug 1421380 - Enable gfx.webrender.hit-test by default. r=jrmuizel This causes some mochitests to fail. MozReview-Commit-ID: J2AjM0qKVE5
dom/events/test/mochitest.ini
dom/events/test/pointerevents/mochitest.ini
gfx/layers/apz/test/mochitest/mochitest.ini
gfx/thebes/gfxPrefs.h
modules/libpref/init/all.js
--- a/dom/events/test/mochitest.ini
+++ b/dom/events/test/mochitest.ini
@@ -170,16 +170,17 @@ skip-if = toolkit == 'android' #CRASH_DU
 [test_eventhandler_scoping.html]
 [test_eventTimeStamp.html]
 [test_focus_disabled.html]
 [test_focus_abspos.html]
 [test_legacy_event.html]
 [test_messageEvent.html]
 [test_messageEvent_init.html]
 [test_moz_mouse_pixel_scroll_event.html]
+skip-if = webrender # bug 1429521 for webrender
 [test_offsetxy.html]
 [test_onerror_handler_args.html]
 [test_passive_listeners.html]
 [test_paste_image.html]
 skip-if = headless # Bug 1405869
 [test_wheel_default_action.html]
 [test_bug687787.html]
 [test_bug1305458.html]
--- a/dom/events/test/pointerevents/mochitest.ini
+++ b/dom/events/test/pointerevents/mochitest.ini
@@ -140,16 +140,18 @@ support-files =
     pointerevent_touch-action-pan-y-css_touch-manual.html
     pointerevent_touch-action-span-test_touch-manual.html
     pointerevent_touch-action-svg-test_touch-manual.html
     pointerevent_touch-action-table-test_touch-manual.html
     pointerevent_touch-action-pan-down-css_touch-manual.html
     pointerevent_touch-action-pan-left-css_touch-manual.html
     pointerevent_touch-action-pan-right-css_touch-manual.html
     pointerevent_touch-action-pan-up-css_touch-manual.html
+  # bug 1429521 for webrender, bug 1432914 for why this isn't an inline comment
+  skip-if = webrender
 [test_trigger_fullscreen_by_pointer_events.html]
   support-files =
     file_test_trigger_fullscreen.html
 [test_trigger_popup_by_pointer_events.html]
 [test_remove_frame_when_got_pointer_capture.html]
 [test_getCoalescedEvents.html]
   skip-if = !e10s
   support-files =
--- a/gfx/layers/apz/test/mochitest/mochitest.ini
+++ b/gfx/layers/apz/test/mochitest/mochitest.ini
@@ -54,31 +54,32 @@
   skip-if = webrender # bug 1424752
 [test_group_mouseevents.html]
   skip-if = (toolkit == 'android') # mouse events not supported on mobile
 [test_group_pointerevents.html]
   skip-if = os == 'win' && os_version == '10.0' # Bug 1404836
 [test_group_touchevents.html]
   skip-if = webrender # bug 1424752
 [test_group_wheelevents.html]
-  skip-if = (toolkit == 'android') # wheel events not supported on mobile
+  skip-if = (toolkit == 'android') || webrender # wheel events not supported on mobile; bug 1429521 for webrender
 [test_group_zoom.html]
   skip-if = (toolkit != 'android') # only android supports zoom
 [test_interrupted_reflow.html]
+  skip-if = webrender # bug 1429521 for webrender
 [test_key_scroll.html]
 [test_layerization.html]
   skip-if = (os == 'android') || webrender # wheel events not supported on mobile; bug 1424752 for webrender
 [test_scroll_inactive_bug1190112.html]
   skip-if = (os == 'android') # wheel events not supported on mobile
 [test_scroll_inactive_flattened_frame.html]
   skip-if = (os == 'android') # wheel events not supported on mobile
 [test_scroll_subframe_scrollbar.html]
   skip-if = (os == 'android') # wheel events not supported on mobile
 [test_touch_listeners_impacting_wheel.html]
   skip-if = (toolkit == 'android') || (toolkit == 'cocoa') # wheel events not supported on mobile, and synthesized wheel smooth-scrolling not supported on OS X
 [test_wheel_scroll.html]
   skip-if = (os == 'android') # wheel events not supported on mobile
 [test_wheel_transactions.html]
-  skip-if = (os == 'android') # wheel events not supported on mobile
+  skip-if = (toolkit == 'android') || webrender # wheel events not supported on mobile; bug 1429521 for webrender
 [test_group_overrides.html]
-  skip-if = (os == 'android') # wheel events not supported on mobile
+  skip-if = (toolkit == 'android') || webrender # wheel events not supported on mobile; bug 1429521 for webrender
 [test_group_hittest.html]
-  skip-if = (toolkit == 'android') || webrender # mouse events not supported on mobile; bug 1424752 for webrender
+  skip-if = (toolkit == 'android') || webrender # mouse events not supported on mobile; bug 1429521 for webrender
--- a/gfx/thebes/gfxPrefs.h
+++ b/gfx/thebes/gfxPrefs.h
@@ -503,17 +503,17 @@ private:
 
   DECL_GFX_PREF(Live, "gfx.vsync.collect-scroll-transforms",   CollectScrollTransforms, bool, false);
   DECL_GFX_PREF(Once, "gfx.vsync.compositor.unobserve-count",  CompositorUnobserveCount, int32_t, 10);
 
   DECL_GFX_PREF(Once, "gfx.webrender.all",                     WebRenderAll, bool, false);
   DECL_GFX_PREF(Once, "gfx.webrender.enabled",                 WebRenderEnabledDoNotUseDirectly, bool, false);
   DECL_OVERRIDE_PREF(Live, "gfx.webrender.blob-images",        WebRenderBlobImages, gfxPrefs::WebRenderAll());
   DECL_GFX_PREF(Live, "gfx.webrender.highlight-painted-layers",WebRenderHighlightPaintedLayers, bool, false);
-  DECL_GFX_PREF(Live, "gfx.webrender.hit-test",                WebRenderHitTest, bool, false);
+  DECL_GFX_PREF(Live, "gfx.webrender.hit-test",                WebRenderHitTest, bool, true);
 
   // Use vsync events generated by hardware
   DECL_GFX_PREF(Once, "gfx.work-around-driver-bugs",           WorkAroundDriverBugs, bool, true);
 
   DECL_GFX_PREF(Live, "gl.ignore-dx-interop2-blacklist",       IgnoreDXInterop2Blacklist, bool, false);
   DECL_GFX_PREF(Live, "gl.msaa-level",                         MSAALevel, uint32_t, 2);
 #if defined(XP_MACOSX)
   DECL_GFX_PREF(Live, "gl.multithreaded",                      GLMultithreaded, bool, false);
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -892,17 +892,17 @@ pref("gfx.webrender.enabled", false);
 #endif
 #ifdef XP_WIN
 pref("gfx.webrender.force-angle", true);
 pref("gfx.webrender.program-binary", true);
 #endif
 
 pref("gfx.webrender.highlight-painted-layers", false);
 pref("gfx.webrender.blob-images", 2);
-pref("gfx.webrender.hit-test", false);
+pref("gfx.webrender.hit-test", true);
 
 // WebRender debugging utilities.
 pref("gfx.webrender.debug.texture-cache", false);
 pref("gfx.webrender.debug.render-targets", false);
 pref("gfx.webrender.debug.alpha-primitives", false);
 pref("gfx.webrender.debug.profiler", false);
 pref("gfx.webrender.debug.gpu-time-queries", false);
 pref("gfx.webrender.debug.gpu-sample-queries", false);