Bug 1372601 - fix title being gone when closing and reopening the sidebar with a webpage loaded, r?bgrins draft
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Thu, 17 Aug 2017 12:24:05 +0100
changeset 648189 5e434382d2a3c9bc650cc65af91dae891cbeae5b
parent 648046 932388b8c22c9775264e543697ce918415db9e23
child 726745 64afce2ac08f0e6125a8c35e3708a34c88dcbe2a
push id74665
push usergijskruitbosch@gmail.com
push dateThu, 17 Aug 2017 11:24:12 +0000
reviewersbgrins
bugs1372601
milestone57.0a1
Bug 1372601 - fix title being gone when closing and reopening the sidebar with a webpage loaded, r?bgrins MozReview-Commit-ID: JvZ5BbVqdz2
browser/base/content/browser-sidebar.js
--- a/browser/base/content/browser-sidebar.js
+++ b/browser/base/content/browser-sidebar.js
@@ -434,17 +434,16 @@ var SidebarUI = {
     // until about:blank has loaded (which does not happen as long as the
     // element is hidden).
     this.browser.setAttribute("src", "about:blank");
     this.browser.docShell.createAboutBlankContentViewer(null);
 
     sidebarBroadcaster.removeAttribute("checked");
     this._box.setAttribute("sidebarcommand", "");
     this._box.removeAttribute("checked");
-    this.title = "";
     this._box.hidden = this._splitter.hidden = true;
 
     let selBrowser = gBrowser.selectedBrowser;
     selBrowser.focus();
     selBrowser.messageManager.sendAsyncMessage("Sidebar:VisibilityChange",
       {commandID, isOpen: false}
     );
     if (triggerNode) {