Bug 1322505 - part1 : rename audio channel wrapper's function. draft
authorAlastor Wu <alwu@mozilla.com>
Mon, 23 Jan 2017 10:52:04 +0800
changeset 464871 5a65bee282f16edd5834a9f1d218589da3d41eab
parent 463800 bde3fc40b9b55435d989393d659a60f46b54fd72
child 464872 384e5db1186c5f2ad5a9abeb13d68efc06e35e93
push id42464
push useralwu@mozilla.com
push dateMon, 23 Jan 2017 06:45:24 +0000
bugs1322505
milestone53.0a1
Bug 1322505 - part1 : rename audio channel wrapper's function. Rename function and modify the comment. MozReview-Commit-ID: F5JTmPvH7GC
dom/html/HTMLMediaElement.cpp
--- a/dom/html/HTMLMediaElement.cpp
+++ b/dom/html/HTMLMediaElement.cpp
@@ -650,22 +650,23 @@ public:
       }
 
       mPlayingThroughTheAudioChannel = playingThroughTheAudioChannel;
       NotifyAudioChannelAgent(mPlayingThroughTheAudioChannel);
     }
   }
 
   void
-  NotifyPlayStarted()
+  NotifyPlayStateChanged()
   {
     MOZ_ASSERT(!mIsShutDown);
-    // Reset the suspend type because the media element might be paused by
-    // audio channel before calling play(). eg. paused by Fennec media control,
-    // but resumed it from page.
+    // When owner's play state changed, we should reset the suspend type. If
+    // owner is playing, the suspend type should be 'NONE_SUSPENDED', and if
+    // owner paused, the suspend type also needs to be reset because the agent
+    // maybe need to be unregistered.
     SetSuspended(nsISuspendedTypes::NONE_SUSPENDED);
     UpdateAudioChannelPlayingState();
   }
 
   NS_IMETHODIMP
   WindowVolumeChanged(float aVolume, bool aMuted) override
   {
     MOZ_ASSERT(mAudioChannelAgent);
@@ -7127,17 +7128,17 @@ HTMLMediaElement::MarkAsContentSource(Ca
        this, isVisible, aAPI));
 }
 
 void
 HTMLMediaElement::UpdateCustomPolicyAfterPlayed()
 {
   OpenUnsupportedMediaWithExternalAppIfNeeded();
   if (mAudioChannelWrapper) {
-    mAudioChannelWrapper->NotifyPlayStarted();
+    mAudioChannelWrapper->NotifyPlayStateChanged();
   }
 }
 
 nsTArray<RefPtr<Promise>>
 HTMLMediaElement::TakePendingPlayPromises()
 {
   return Move(mPendingPlayPromises);
 }