Bug 1480532 - Remove Reload All Tabs from context menu draft remove-reload-all-tabs
authorBen Thayer <ben@benthayer.com>
Wed, 15 Aug 2018 15:52:27 -0500
branchremove-reload-all-tabs
changeset 829703 57cb9810e5486c592c15a59c3258186d54acccfe
parent 828526 7ed5ed3d48146ef939a6ca4cba221430128ba5f5
push id118794
push userbmo:ben@benthayer.com
push dateThu, 16 Aug 2018 21:04:30 +0000
bugs1480532
milestone63.0a1
Bug 1480532 - Remove Reload All Tabs from context menu r?amylee MozReview-Commit-ID: Ix4oJH1oWvU
browser/base/content/browser.xul
browser/base/content/tabbrowser.js
browser/locales/en-US/chrome/browser/browser.dtd
--- a/browser/base/content/browser.xul
+++ b/browser/base/content/browser.xul
@@ -124,19 +124,16 @@
       <menuseparator id="context_sendTabToDevice_separator" class="sync-ui-item"/>
       <menu id="context_sendTabToDevice" label="&sendTabToDevice.label;"
             class="sync-ui-item"
             accesskey="&sendTabToDevice.accesskey;">
         <menupopup id="context_sendTabToDevicePopupMenu"
                    onpopupshowing="gSync.populateSendTabToDevicesMenu(event.target, TabContextMenu.contextTab.linkedBrowser.currentURI.spec, TabContextMenu.contextTab.linkedBrowser.contentTitle);"/>
       </menu>
       <menuseparator/>
-      <menuitem id="context_reloadAllTabs" label="&reloadAllTabs.label;" accesskey="&reloadAllTabs.accesskey;"
-                tbattr="tabbrowser-multiple-visible"
-                oncommand="gBrowser.reloadAllTabs();"/>
        <menuitem id="context_bookmarkSelectedTabs"
                 hidden="true"
                 label="&bookmarkSelectedTabs.label;"
                 accesskey="&bookmarkSelectedTabs.accesskey;"
                 oncommand="PlacesCommandHook.bookmarkPages(PlacesCommandHook.uniqueSelectedPages);"/>
       <menuitem id="context_bookmarkAllTabs"
                 label="&bookmarkAllTabs.label;"
                 accesskey="&bookmarkAllTabs.accesskey;"
--- a/browser/base/content/tabbrowser.js
+++ b/browser/base/content/tabbrowser.js
@@ -3322,20 +3322,16 @@ window._gBrowser = {
       aOurBrowser.registeredOpenURI = aOtherBrowser.registeredOpenURI;
       delete aOtherBrowser.registeredOpenURI;
     }
     if (tmp) {
       aOtherBrowser.registeredOpenURI = tmp;
     }
   },
 
-  reloadAllTabs() {
-    this.reloadTabs(this.visibleTabs);
-  },
-
   reloadMultiSelectedTabs() {
     this.reloadTabs(this.selectedTabs);
   },
 
   reloadTabs(tabs) {
     for (let tab of tabs) {
       try {
         this.getBrowserForTab(tab).reload();
--- a/browser/locales/en-US/chrome/browser/browser.dtd
+++ b/browser/locales/en-US/chrome/browser/browser.dtd
@@ -16,18 +16,16 @@
 <!ENTITY mainWindow.titlePrivateBrowsingSuffix "(Private Browsing)">
 
 <!ENTITY appmenu.tooltip                     "Open menu">
 <!ENTITY navbarOverflow.label                "More tools…">
 
 <!-- Tab context menu -->
 <!ENTITY  reloadTab.label                    "Reload Tab">
 <!ENTITY  reloadTab.accesskey                "R">
-<!ENTITY  reloadAllTabs.label                "Reload All Tabs">
-<!ENTITY  reloadAllTabs.accesskey            "A">
 <!-- LOCALIZATION NOTE (duplicateTab.label): This is a command to duplicate
 a tab (i.e. it is a verb, not adjective). -->
 <!ENTITY  duplicateTab.label                 "Duplicate Tab">
 <!ENTITY  duplicateTab.accesskey             "D">
 <!-- LOCALIZATION NOTE (closeTabsToTheEnd.label): This should indicate the
 direction in which tabs are closed, i.e. locales that use RTL mode should say
 left instead of right. -->
 <!ENTITY  closeTabsToTheEnd.label            "Close Tabs to the Right">