Bug 1476644: Fix DEAD_STORE error in media/webrtc/signaling/gtest/videoconduit_unittests.cpp. r?ekr draft
authorRobert Bartlensky <rbartlensky@mozilla.com>
Thu, 19 Jul 2018 14:07:06 +0100
changeset 820377 553e07d90851
parent 820131 5a8107262015
push id116799
push userbmo:rbartlensky@mozilla.com
push dateThu, 19 Jul 2018 13:08:29 +0000
reviewersekr
bugs1476644
milestone63.0a1
Bug 1476644: Fix DEAD_STORE error in media/webrtc/signaling/gtest/videoconduit_unittests.cpp. r?ekr MozReview-Commit-ID: 8QRXhxgqYXm
media/webrtc/signaling/gtest/videoconduit_unittests.cpp
--- a/media/webrtc/signaling/gtest/videoconduit_unittests.cpp
+++ b/media/webrtc/signaling/gtest/videoconduit_unittests.cpp
@@ -776,16 +776,17 @@ TEST_F(VideoConduitTest, TestConfigureSe
   encoding2.constraints.scaleDownBy = 2;
   encoding3.constraints.scaleDownBy = 4;
 
   VideoCodecConfig codecConfig(120, "VP8", constraints);
   codecConfig.mSimulcastEncodings.push_back(encoding);
   codecConfig.mSimulcastEncodings.push_back(encoding2);
   codecConfig.mSimulcastEncodings.push_back(encoding3);
   ec = mVideoConduit->ConfigureCodecMode(webrtc::VideoCodecMode::kScreensharing);
+  ASSERT_EQ(ec, kMediaConduitNoError);
   ec = mVideoConduit->ConfigureSendMediaCodec(&codecConfig);
   ASSERT_EQ(ec, kMediaConduitNoError);
   mVideoConduit->StartTransmitting();
   std::vector<webrtc::VideoStream> videoStreams;
   videoStreams = mCall->mEncoderConfig.video_stream_factory->CreateEncoderStreams(640, 480, mCall->mEncoderConfig);
   ASSERT_EQ(videoStreams.size(), 1U);
   mVideoConduit->StopTransmitting();
 }