Bug 1289157 - Removed eSurvivingInUpdate flag and corresponding function r?surkov draft
authorNick <nick@foxsec.io>
Thu, 02 Mar 2017 15:52:08 -0500
changeset 493012 5511c86ae3718822d2a8d5bdfb85ee1e3df8c1bd
parent 493011 fec75317497e9bcfa76b2ca69ec456d665ce8407
child 547736 6e3726e034fd0a6d2999882f59e11fa5ed2a592d
push id47623
push usernick@foxsec.io
push dateFri, 03 Mar 2017 04:43:44 +0000
reviewerssurkov
bugs1289157
milestone54.0a1
Bug 1289157 - Removed eSurvivingInUpdate flag and corresponding function r?surkov MozReview-Commit-ID: 60Zp8CC6FqJ
accessible/generic/Accessible.h
--- a/accessible/generic/Accessible.h
+++ b/accessible/generic/Accessible.h
@@ -895,29 +895,16 @@ public:
    * DOM UI event, if otherwise then false. For example, HTMLCheckboxAccessible
    * process nsIDocumentObserver::ContentStateChanged instead
    * 'CheckboxStateChange' event.
    */
   bool NeedsDOMUIEvent() const
     { return !(mStateFlags & eIgnoreDOMUIEvent); }
 
   /**
-   * Get/set survivingInUpdate bit on child indicating that parent recollects
-   * its children.
-   */
-  bool IsSurvivingInUpdate() const { return mStateFlags & eSurvivingInUpdate; }
-  void SetSurvivingInUpdate(bool aIsSurviving)
-  {
-    if (aIsSurviving)
-      mStateFlags |= eSurvivingInUpdate;
-    else
-      mStateFlags &= ~eSurvivingInUpdate;
-  }
-
-  /**
    * Get/set repositioned bit indicating that the accessible was moved in
    * the accessible tree, i.e. the accessible tree structure differs from DOM.
    */
   bool IsRelocated() const { return mStateFlags & eRelocated; }
   void SetRelocated(bool aRelocated)
   {
     if (aRelocated)
       mStateFlags |= eRelocated;
@@ -1034,21 +1021,20 @@ protected:
     eIsDefunct = 1 << 0, // accessible is defunct
     eIsNotInDocument = 1 << 1, // accessible is not in document
     eSharedNode = 1 << 2, // accessible shares DOM node from another accessible
     eNotNodeMapEntry = 1 << 3, // accessible shouldn't be in document node map
     eHasNumericValue = 1 << 4, // accessible has a numeric value
     eGroupInfoDirty = 1 << 5, // accessible needs to update group info
     eKidsMutating = 1 << 6, // subtree is being mutated
     eIgnoreDOMUIEvent = 1 << 7, // don't process DOM UI events for a11y events
-    eSurvivingInUpdate = 1 << 8, // parent drops children to recollect them
-    eRelocated = 1 << 9, // accessible was moved in tree
-    eNoXBLKids = 1 << 10, // accessible don't allows XBL children
-    eNoKidsFromDOM = 1 << 11, // accessible doesn't allow children from DOM
-    eHasTextKids = 1 << 12, // accessible have a text leaf in children
+    eRelocated = 1 << 8, // accessible was moved in tree
+    eNoXBLKids = 1 << 9, // accessible don't allows XBL children
+    eNoKidsFromDOM = 1 << 10, // accessible doesn't allow children from DOM
+    eHasTextKids = 1 << 11, // accessible have a text leaf in children
 
     eLastStateFlag = eNoKidsFromDOM
   };
 
   /**
    * Flags used for contextual information about the accessible.
    */
   enum ContextFlags {
@@ -1139,17 +1125,17 @@ protected:
   // Data Members
   nsCOMPtr<nsIContent> mContent;
   RefPtr<DocAccessible> mDoc;
 
   Accessible* mParent;
   nsTArray<Accessible*> mChildren;
   int32_t mIndexInParent;
 
-  static const uint8_t kStateFlagsBits = 13;
+  static const uint8_t kStateFlagsBits = 12;
   static const uint8_t kContextFlagsBits = 3;
   static const uint8_t kTypeBits = 6;
   static const uint8_t kGenericTypesBits = 16;
 
   /**
    * Non-NO_ROLE_MAP_ENTRY_INDEX indicates author-supplied role;
    * possibly state & value as well
    */