Backed out changeset 6b52ab7a62ed (bug 1400912) for mda failures, e.g. in dom/media/tests/mochitest/test_peerConnection_addSecondVideoStreamNoBundle.html and media related mochitest failures. r=backout on a CLOSED TREE
authorSebastian Hengst <archaeopteryx@coole-files.de>
Fri, 22 Sep 2017 16:21:46 +0200
changeset 669146 53af3cecd1464ecda960d6e99cba8b1a0ddbc65b
parent 669145 6b52ab7a62ed59b6ab7a12e3a0bda3d8d2788594
child 669147 9e3f77db6b22d578e48da2d0318fc62c74fd4d18
push id81223
push usergpascutto@mozilla.com
push dateFri, 22 Sep 2017 15:21:17 +0000
reviewersbackout
bugs1400912
milestone58.0a1
backs out6b52ab7a62ed59b6ab7a12e3a0bda3d8d2788594
Backed out changeset 6b52ab7a62ed (bug 1400912) for mda failures, e.g. in dom/media/tests/mochitest/test_peerConnection_addSecondVideoStreamNoBundle.html and media related mochitest failures. r=backout on a CLOSED TREE
dom/media/systemservices/CamerasChild.cpp
--- a/dom/media/systemservices/CamerasChild.cpp
+++ b/dom/media/systemservices/CamerasChild.cpp
@@ -251,18 +251,18 @@ private:
   const char* mRequestingFunc;
   nsIRunnable* mRunnable;
   // Prevent concurrent use of the reply variables by holding
   // the mReplyMonitor. Note that this is unlocked while waiting for
   // the reply to be filled in, necessitating the additional mRequestLock/Mutex;
   MonitorAutoLock mReplyLock;
   MutexAutoLock mRequestLock;
   bool mSuccess;
-  const T mFailureValue;
-  const T mSuccessValue;
+  const T& mFailureValue;
+  const T& mSuccessValue;
 };
 
 bool
 CamerasChild::DispatchToParent(nsIRunnable* aRunnable,
                                MonitorAutoLock& aMonitor)
 {
   CamerasSingleton::Mutex().AssertCurrentThreadOwns();
   CamerasSingleton::Thread()->Dispatch(aRunnable, NS_DISPATCH_NORMAL);