Bug 1418191 - not send the CTA telemetry event ping when instant complete;r=Fischer
authorFred Lin <gasolin@gmail.com>
Tue, 21 Nov 2017 13:12:56 +0800
changeset 701872 5378dcb45044a160fad93b02eed0c617f3324dbc
parent 701871 931eb8bca980a9b603c616f41e5b181fc8e0bdfb
child 701873 c918e480c03938f4cead22acbd171c9cd95521ba
child 701874 667c958dbf8ceaf531811b016ae476b49dd5cc99
child 701878 628bd43c112db34a405b536c200f9693eab319f1
child 701906 b02047ad5ee7326788bbb8143bc1cf1b7d7a5e72
child 701940 b61ba501efd9ecb43689edf7ca23c521a3d46176
child 701942 2fab2685cf4ac79af89cbf2b9a217c1b3d55eba5
child 701943 1040f13fa3fcab02005c56d0befb78f173a8fb18
child 701950 d903370434b5e34593eef92ebb9b711ba32b3a0c
child 701976 504554b99df5954750b637526dc50636971e1708
child 701988 7daceb99c44a811bb0052441b387a468c3e93328
child 701989 13915226e2fd5fef92b004cffac416d7a857e640
child 701992 0b65bf6cdfaed282013e752064e8dfe9b7e4b9b9
child 701996 96f5f00b3112b65b1e63a42f9dfa7c07dc24d73b
child 702001 efe0edd00c069b564a93b0597374ed570b95c58e
child 702002 f9fb255a5cb3b2e4947a6b9717fbccc39363814e
child 702005 f28b35d85c15cf926e68a8e48d5e187797a35980
child 702006 3593278c01d1cc034cc692c6e9152371bf629b72
child 702007 4ed82ca3f97ce1b00acd76a754b760c85c35c3a1
child 702033 61d678f7778c9d8aa400bc684814bd8fc2e85272
child 702034 a778fbd11002d1229fa56753b0d4efe20545255c
child 702035 9f9c89d8a40d6ae4de5634d19bd3c4950207644a
child 702036 05a913c5cf3f9f9577d103352c6a593b8fa4fd60
child 702050 b2e3923f39e04bc571935141a9b9062d7523f03d
child 702051 51aa7945ebebdcb0e60788d04f9d88c51688734e
child 702151 1ddc65ab1717835bbad9b2739df7b84f99fd8e97
child 702170 665727d54afca0c15d8545e9175b52b6601c7508
child 702203 c3be9850edb5b24045703058e44458269313ea9f
child 702204 7ca94f459acf231f774d3db2e7f8d0d1d4a8e0bb
child 702271 b9e7e1b70d06ad40a57ab1497506f4bf972fe70a
child 702396 f6c3b3c66cd1f02899ebad22d79fbf499d160a4f
child 702458 24bb5172bddf64d536d3549d059be190dc240edb
child 702474 7c64a644f7ffc00b6555e78c8ee3373423e079cd
child 702483 6e46b1cec119b6b7ecc6b1fbd9be8c545cfcff0a
child 702510 071d350b83953eef3d1b8b3997e17056055f5597
child 702511 bbde5fa6e95ea2ff6b10f7a6ef5f26b2620e105d
child 702636 12fca582a953ebf7aabb6d2ef2a0ddacac5cba58
child 702642 86f94c0ec99821d9610ce2a4329d7a79d38cfa06
child 703153 9c15f8c029b0b44af5f77771f0b4d13c555f8be3
child 703156 975d80e4c57c9f6a1c0ab5408d322056a3571328
child 703158 d992e8654bc66114a268f157c0573795ef7cb6e9
child 703160 3b5a3afbe5e08fc9229a5c227f36613421eb10a6
child 703683 a521d3800deda2561a9c4b1f72d73b36e3e4f815
child 703696 ea62803ad3daff39b0f69bd35dc22dc5451e6b2e
child 703697 1e3302996aa78d30710d69924426f8c5b3ec3d2f
push id90298
push userbmo:bpostelnicu@mozilla.com
push dateWed, 22 Nov 2017 10:54:01 +0000
reviewersFischer
bugs1418191
milestone59.0a1
Bug 1418191 - not send the CTA telemetry event ping when instant complete;r=Fischer MozReview-Commit-ID: 9KJazfZqviT
browser/extensions/onboarding/content/onboarding.js
--- a/browser/extensions/onboarding/content/onboarding.js
+++ b/browser/extensions/onboarding/content/onboarding.js
@@ -815,22 +815,16 @@ class Onboarding {
           event: "overlay-nav-click",
           tour_id: tourId,
           session_key: this._session_key,
         });
 
         // Some tours should complete instantly upon showing.
         if (tab.getAttribute("data-instant-complete")) {
           this.setToursCompleted([tourId]);
-          // Also track auto-completed tour so we can filter data with the same event.
-          telemetry({
-            event: "overlay-cta-click",
-            tour_id: tourId,
-            session_key: this._session_key,
-          });
         }
       } else {
         tab.classList.remove("onboarding-active");
         tab.setAttribute("aria-selected", false);
       }
     }
   }