Bug 1265818 followup: touch CLOBBER after converting nsILayoutHistoryState.h to .idl. rs=mccr8
authorDaniel Holbert <dholbert@cs.stanford.edu>
Tue, 28 Mar 2017 14:20:44 -0700
changeset 552743 4e53b8baa32e585d11c4f591eba3df63ec4d7736
parent 552742 a73dcfe2c3823422a2f9f1bec57ccb34a1ac8f4e
child 552744 92fe8848d8b733fa9614024083dc53f2a733bf6a
push id51444
push usercykesiopka.bmo@gmail.com
push dateTue, 28 Mar 2017 23:22:36 +0000
reviewersmccr8
bugs1265818
milestone55.0a1
Bug 1265818 followup: touch CLOBBER after converting nsILayoutHistoryState.h to .idl. rs=mccr8 Without a clobber, the build may generate untracked copies of the generated .h file in your source directory. This probably happens because your objdir may be left with a stray symlink for this header, with the stray symlink pointing at the now-missing version of the header in your source directory. And when build generates a .h file (from the new IDL file) in your objdir, it lands on top of that symlink, which effectively recreates a version of the header in your source directory. MozReview-Commit-ID: Ew0aP6PM1Ms
CLOBBER
--- a/CLOBBER
+++ b/CLOBBER
@@ -17,9 +17,9 @@
 #
 # Modifying this file will now automatically clobber the buildbot machines \o/
 #
 
 # Are you updating CLOBBER because you think it's needed for your WebIDL
 # changes to stick? As of bug 928195, this shouldn't be necessary! Please
 # don't change CLOBBER for WebIDL changes any more.
 
-Bug 1343682 - backing out a previous version didn't stop the failures from it, so it appears to need a clobber both out and in
+Bug 1265818 - deleted an exported header and added a new .idl to regenerate that same header; and this unfortunately produces an untracked generated header in your source dir whenever you build (probably due to a dangling symlink), unless you clobber