Bug 1380461: Clarify ancient code-comment about the helper-variables we use as AddRemoveScrollbar outparams. r?jfkthame
MozReview-Commit-ID: Fxzes2yuLHJ
--- a/layout/generic/nsGfxScrollFrame.cpp
+++ b/layout/generic/nsGfxScrollFrame.cpp
@@ -4827,41 +4827,45 @@ nsXULScrollFrame::AddRemoveScrollbar(nsB
if (mHelper.mNeverHasHorizontalScrollbar || !mHelper.mHScrollbarBox)
return false;
nsSize hSize = mHelper.mHScrollbarBox->GetXULPrefSize(aState);
nsBox::AddMargin(mHelper.mHScrollbarBox, hSize);
mHelper.SetScrollbarVisibility(mHelper.mHScrollbarBox, aAdd);
+ // We can't directly pass mHasHorizontalScrollbar as the bool outparam for
+ // AddRemoveScrollbar, because it's a bool:1 bitfield. Hence this var:
bool hasHorizontalScrollbar;
bool fit = AddRemoveScrollbar(hasHorizontalScrollbar,
mHelper.mScrollPort.y,
mHelper.mScrollPort.height,
hSize.height, aOnRightOrBottom, aAdd);
- mHelper.mHasHorizontalScrollbar = hasHorizontalScrollbar; // because mHasHorizontalScrollbar is a bool
+ mHelper.mHasHorizontalScrollbar = hasHorizontalScrollbar;
if (!fit)
mHelper.SetScrollbarVisibility(mHelper.mHScrollbarBox, !aAdd);
return fit;
} else {
if (mHelper.mNeverHasVerticalScrollbar || !mHelper.mVScrollbarBox)
return false;
nsSize vSize = mHelper.mVScrollbarBox->GetXULPrefSize(aState);
nsBox::AddMargin(mHelper.mVScrollbarBox, vSize);
mHelper.SetScrollbarVisibility(mHelper.mVScrollbarBox, aAdd);
+ // We can't directly pass mHasVerticalScrollbar as the bool outparam for
+ // AddRemoveScrollbar, because it's a bool:1 bitfield. Hence this var:
bool hasVerticalScrollbar;
bool fit = AddRemoveScrollbar(hasVerticalScrollbar,
mHelper.mScrollPort.x,
mHelper.mScrollPort.width,
vSize.width, aOnRightOrBottom, aAdd);
- mHelper.mHasVerticalScrollbar = hasVerticalScrollbar; // because mHasVerticalScrollbar is a bool
+ mHelper.mHasVerticalScrollbar = hasVerticalScrollbar;
if (!fit)
mHelper.SetScrollbarVisibility(mHelper.mVScrollbarBox, !aAdd);
return fit;
}
}
bool