Bug 1405942 - Make sure to always apply the descriptionHeightWorkaround in Photon panels on popupshown, because it might've missed elements that were hidden. r?Gijs draft
authorMike de Boer <mdeboer@mozilla.com>
Tue, 10 Oct 2017 12:41:07 +0200
changeset 677222 4aeda1226680c95ac55dd27bb8d81d2a97f56575
parent 677221 8126d13f7be94cacae8e4415b76a8d2a937f5ace
child 735146 b4ac63b282a817c5ac62d952a8492958dca47fcf
push id83724
push usermdeboer@mozilla.com
push dateTue, 10 Oct 2017 10:47:26 +0000
reviewersGijs
bugs1405942
milestone58.0a1
Bug 1405942 - Make sure to always apply the descriptionHeightWorkaround in Photon panels on popupshown, because it might've missed elements that were hidden. r?Gijs MozReview-Commit-ID: 9xSqoZGJ3MF
browser/components/customizableui/PanelMultiView.jsm
--- a/browser/components/customizableui/PanelMultiView.jsm
+++ b/browser/components/customizableui/PanelMultiView.jsm
@@ -1043,18 +1043,17 @@ this.PanelMultiView = class {
             blockInBoxWorkaround();
           }
         }
         break;
       }
       case "popupshown":
         // Now that the main view is visible, we can check the height of the
         // description elements it contains.
-        if (!this.panelViews)
-          this.descriptionHeightWorkaround();
+        this.descriptionHeightWorkaround();
         break;
       case "popuphidden": {
         // WebExtensions consumers can hide the popup from viewshowing, or
         // mid-transition, which disrupts our state:
         this._viewShowing = null;
         this._transitioning = false;
         this.node.removeAttribute("panelopen");
         this.showMainView();