Bug 1447982 - Mic source's ApplySettings shouldn't have weird side effects. r?padenot draft
authorAndreas Pehrson <pehrsons@mozilla.com>
Mon, 26 Mar 2018 11:04:51 +0200
changeset 781067 42fda6bb04ab8daebd409af919942808b32c736b
parent 781066 1ec795379f625315755b0f7fc658e660bce6c929
child 781068 c0b40d29e6cbfe04539c029d59edb0a6f7f6a6b3
push id106197
push userbmo:apehrson@mozilla.com
push dateThu, 12 Apr 2018 13:32:52 +0000
reviewerspadenot
bugs1447982
milestone61.0a1
Bug 1447982 - Mic source's ApplySettings shouldn't have weird side effects. r?padenot MozReview-Commit-ID: DCVi5Wy4WN2
dom/media/webrtc/MediaEngineWebRTCAudio.cpp
--- a/dom/media/webrtc/MediaEngineWebRTCAudio.cpp
+++ b/dom/media/webrtc/MediaEngineWebRTCAudio.cpp
@@ -525,18 +525,16 @@ MediaEngineWebRTCMicrophoneSource::Updat
 
 #undef HANDLE_APM_ERROR
 
 void
 MediaEngineWebRTCMicrophoneSource::ApplySettings(const MediaEnginePrefs& aPrefs)
 {
   AssertIsOnOwningThread();
 
-  mLastPrefs = aPrefs;
-
   RefPtr<MediaEngineWebRTCMicrophoneSource> that = this;
   RefPtr<MediaStreamGraphImpl> graph;
   for (const Allocation& allocation : mAllocations) {
     if (allocation.mStream && allocation.mStream->GraphImpl()) {
       graph = allocation.mStream->GraphImpl();
       break;
     }
   }