Bug 1364651 - annotate mach bash hack; r=Callek draft
authorRob Thijssen <rthijssen@mozilla.com>
Mon, 12 Jun 2017 12:19:05 +0300
changeset 593333 41e6ce21e403
parent 592464 27cad9749cdd
child 633073 67efc0f0bcc3
push id63655
push userrthijssen@mozilla.com
push dateTue, 13 Jun 2017 12:45:19 +0000
reviewersCallek
bugs1364651
milestone55.0a1
Bug 1364651 - annotate mach bash hack; r=Callek MozReview-Commit-ID: AQHeHLBABZg
testing/mozharness/mozharness/mozilla/building/buildbase.py
--- a/testing/mozharness/mozharness/mozilla/building/buildbase.py
+++ b/testing/mozharness/mozharness/mozilla/building/buildbase.py
@@ -1618,16 +1618,18 @@ or run without that action (ie: --no-{ac
         buildprops = os.path.join(dirs['base_work_dir'], 'buildprops.json')
         # not finding buildprops is not an error outside of buildbot
         if os.path.exists(buildprops):
             self.copyfile(
                 buildprops,
                 os.path.join(dirs['abs_work_dir'], 'buildprops.json'))
 
         if 'MOZILLABUILD' in os.environ:
+            # We found many issues with intermittent build failures when not invoking mach via bash.
+            # See bug 1364651 before considering changing.
             mach = [
                 os.path.join(os.environ['MOZILLABUILD'], 'msys', 'bin', 'bash.exe'),
                 os.path.join(dirs['abs_src_dir'], 'mach')
             ]
         else:
             mach = [sys.executable, 'mach']
 
         return_code = self.run_command_m(