Bug 1466573 - Avoid resetting stdout + stderr. r?whimboo
The std::process::Command's stdout and stderr is configured earlier in
::start(), and resetting it to a static value below would invalidate the
configured stdout and stderr stored in FirefoxRunner::stdout and ::stderr.
We did not notice this bug because geckodriver does not
yet use this feature. It was added as a precursor for
https://bugzilla.mozilla.org/show_bug.cgi?id=1466573.
MozReview-Commit-ID: CmwqCZpEMqq
--- a/testing/mozbase/rust/mozrunner/src/runner.rs
+++ b/testing/mozbase/rust/mozrunner/src/runner.rs
@@ -260,17 +260,16 @@ impl Runner for FirefoxRunner {
cmd.args(&self.args[..])
.envs(&self.envs)
.stdout(stdout)
.stderr(stderr);
if !self.args.iter().any(|x| is_profile_arg(x)) {
cmd.arg("-profile").arg(&self.profile.path);
}
- cmd.stdout(Stdio::inherit()).stderr(Stdio::inherit());
info!("Running command: {:?}", cmd);
let process = cmd.spawn()?;
Ok(FirefoxProcess {
process,
profile: self.profile
})
}