Bug 1314573 - Uses Reps in long mode in the console; r=bgrins
In the MessageBody component, we already have the "mode" props we use
to pass it to the Reps. We only default it to "long" so most of the
message will use it.
We only need to specify to use "short" mode in ConsoleTable cells.
MozReview-Commit-ID: 6KyZkN86bHJ
--- a/devtools/client/webconsole/new-console-output/components/console-table.js
+++ b/devtools/client/webconsole/new-console-output/components/console-table.js
@@ -53,17 +53,18 @@ const ConsoleTable = createClass({
getRows: function (columns, items) {
return items.map(item => {
let cells = [];
columns.forEach((value, key) => {
cells.push(
dom.td(
{},
GripMessageBody({
- grip: item[key]
+ grip: item[key],
+ mode: "short",
})
)
);
});
return dom.tr({}, cells);
});
},
--- a/devtools/client/webconsole/new-console-output/components/grip-message-body.js
+++ b/devtools/client/webconsole/new-console-output/components/grip-message-body.js
@@ -32,16 +32,20 @@ GripMessageBody.propTypes = {
PropTypes.object,
]).isRequired,
serviceContainer: PropTypes.shape({
createElement: PropTypes.func.isRequired,
}),
userProvidedStyle: PropTypes.string,
};
+GripMessageBody.defaultProps = {
+ mode: "long",
+};
+
function GripMessageBody(props) {
const { grip, userProvidedStyle, serviceContainer } = props;
let styleObject;
if (userProvidedStyle && userProvidedStyle !== "") {
styleObject = cleanupStyle(userProvidedStyle, serviceContainer.createElement);
}
