Bug 1414838 - Show stop button again as soon as page loading starts. r?snorp draft
authorJan Henning <jh+bugzilla@buttercookie.de>
Mon, 06 Nov 2017 20:20:57 +0100
changeset 693683 38e88fec15ec36955234dc0f22933695c4fef97c
parent 693302 aa808b6bc79cc0f1ba3a03420483020079fc3ba2
child 693690 44644606796cc07edb134e3a2cf9c047dfe328c2
child 693691 08117ed4af3528e84532062e6cc72b23c03e48d2
child 693692 979b13983d8114de86fa9c4ff6526a664a530e2e
push id87893
push usermozilla@buttercookie.de
push dateMon, 06 Nov 2017 19:22:37 +0000
reviewerssnorp
bugs1414838, 1366672
milestone58.0a1
Bug 1414838 - Show stop button again as soon as page loading starts. r?snorp As of bug 1366672, case START no longer falls through in order to allow for a different behaviour of the progress indicator, however we still need to add UpdateFlags.PROGRESS, so that the stop button shows up as soon as a page starts loading. MozReview-Commit-ID: 3P33JEsS5ic
mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbar.java
--- a/mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbar.java
+++ b/mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbar.java
@@ -459,16 +459,17 @@ public abstract class BrowserToolbar ext
         }
 
         if (tabs.isSelectedTab(tab)) {
             final EnumSet<UpdateFlags> flags = EnumSet.noneOf(UpdateFlags.class);
 
             // Progress-related handling
             switch (msg) {
                 case START:
+                    flags.add(UpdateFlags.PROGRESS);
                     updateProgressVisibility(tab, Tab.LOAD_PROGRESS_INIT);
                     break;
                 case ADDED:
                 case LOCATION_CHANGE:
                 case LOAD_ERROR:
                 case LOADED:
                 case STOP:
                     flags.add(UpdateFlags.PROGRESS);