Bug 1410911 - Only run test-verify when certain file types are changed; r=dustin
authorGeoff Brown <gbrown@mozilla.com>
Tue, 24 Oct 2017 15:17:27 -0600
changeset 685873 37db725b23082b69fdf4e3b08242e592a379b60e
parent 685872 4dfe93e7c0811d6c130e4e56c967909fec494b03
child 685874 a6d85f1f40c99a020887a241fb9f8921009a808f
push id86026
push usernnethercote@mozilla.com
push dateWed, 25 Oct 2017 04:01:04 +0000
reviewersdustin
bugs1410911
milestone58.0a1
Bug 1410911 - Only run test-verify when certain file types are changed; r=dustin When first introduced, test-verify was only run when .js/.html/.xul/.xhtml files were changed. Recently, it seems to run on every push. This is a speculative fix: There may be confusion between "test-verify" and "test-verification" so I am using "test-verify" consistently.
moz.build
python/mozbuild/mozbuild/schedules.py
taskcluster/ci/test/misc.yml
taskcluster/taskgraph/transforms/tests.py
--- a/moz.build
+++ b/moz.build
@@ -45,26 +45,26 @@ with Files('**/l10n.toml'):
 with Files('README.txt'):
     BUG_COMPONENT = ('Core', 'General')
 
 with Files('**/Makefile.in'):
     BUG_COMPONENT = ('Core', 'Build Config')
     FINAL = True
 
 with Files("**/*.js"):
-    SCHEDULES.inclusive += ['test-verification']
+    SCHEDULES.inclusive += ['test-verify']
 
 with Files("**/*.html"):
-    SCHEDULES.inclusive += ['test-verification']
+    SCHEDULES.inclusive += ['test-verify']
 
 with Files("**/*.xhtml"):
-    SCHEDULES.inclusive += ['test-verification']
+    SCHEDULES.inclusive += ['test-verify']
 
 with Files("**/*.xul"):
-    SCHEDULES.inclusive += ['test-verification']
+    SCHEDULES.inclusive += ['test-verify']
 
 FILES_PER_UNIFIED_FILE = 1
 
 CONFIGURE_SUBST_FILES += [
     'config/autoconf.mk',
     'config/emptyvars.mk',
 ]
 
--- a/python/mozbuild/mozbuild/schedules.py
+++ b/python/mozbuild/mozbuild/schedules.py
@@ -12,17 +12,17 @@ from __future__ import absolute_import, 
 # TODO: ideally these lists could be specified in moz.build itself
 
 INCLUSIVE_COMPONENTS = [
     'py-lint',
     'js-lint',
     'yaml-lint',
     # test suites that only run when certain files have changed
     'jittest',
-    'test-verification',
+    'test-verify',
     # test flavors (narrower than suites)
     'jsreftest',
 ]
 INCLUSIVE_COMPONENTS = sorted(INCLUSIVE_COMPONENTS)
 
 EXCLUSIVE_COMPONENTS = [
     # os families
     'android',
--- a/taskcluster/ci/test/misc.yml
+++ b/taskcluster/ci/test/misc.yml
@@ -45,17 +45,17 @@ telemetry-tests-client:
         config:
             by-test-platform:
                 linux.*:
                     - remove_executables.py
                 windows.*: []
 
 test-verify:
     description: "Extra verification of tests modified on this push"
-    suite: test-verification
+    suite: test-verify
     treeherder-symbol: tc(TV)
     loopback-video: true
     max-run-time: 5400
     allow-software-gl-layers: false
     run-on-projects:
         by-test-platform:
             # do not run on ccov; see also the enable_code_coverage transform
             linux64-ccov/.*: []
--- a/taskcluster/taskgraph/transforms/tests.py
+++ b/taskcluster/taskgraph/transforms/tests.py
@@ -635,17 +635,17 @@ def handle_suite_category(config, tests)
             suite = flavor = test['suite']
 
         test.setdefault('attributes', {})
         test['attributes']['unittest_suite'] = suite
         test['attributes']['unittest_flavor'] = flavor
 
         script = test['mozharness']['script']
         category_arg = None
-        if suite == 'test-verification':
+        if suite == 'test-verify':
             pass
         elif script == 'android_emulator_unittest.py':
             category_arg = '--test-suite'
         elif script == 'desktop_unittest.py':
             category_arg = '--{}-suite'.format(suite)
 
         if category_arg:
             test['mozharness'].setdefault('extra-options', [])