Bug 1395761: Remove layout_gravity=center in webpage_item_row. r=liuche draft
authorMichael Comella <michael.l.comella@gmail.com>
Mon, 11 Sep 2017 10:09:10 -0700
changeset 662399 3484fc8a0257323c51d805c57979b0904e596483
parent 660845 3c96d611ebd67fc219d22bcb476a72412c76f6c7
child 730858 2ca275e41fa219d3e7c3de72b64fbf1adfc1af41
push id79073
push usermichael.l.comella@gmail.com
push dateMon, 11 Sep 2017 17:09:31 +0000
reviewersliuche
bugs1395761
milestone57.0a1
Bug 1395761: Remove layout_gravity=center in webpage_item_row. r=liuche This has the effect of: - Aligning the webpage item row with top sites (both 10dp margins) - Making the icons not cut off Unfortunately, I don't know why this solved the problem considering the size of the container did not change. However, the layout_gravity was extraneous and given all the other work we have to do, I'm fine not researching further. One thing I noticed is that with layout_gravity, there was an additional non-colored space in the "Show Layout Bounds" mode with layout_gravity than there was with out it. MozReview-Commit-ID: KTZRi1s32gx
mobile/android/app/src/main/res/layout/activity_stream_webpage_item_row.xml
--- a/mobile/android/app/src/main/res/layout/activity_stream_webpage_item_row.xml
+++ b/mobile/android/app/src/main/res/layout/activity_stream_webpage_item_row.xml
@@ -20,17 +20,16 @@
         <org.mozilla.gecko.activitystream.homepanel.stream.StreamOverridablePageIconLayout
                 android:id="@+id/page_icon"
                 android:layout_width="@dimen/favicon_bg"
                 android:layout_height="@dimen/favicon_bg"
                 android:layout_marginStart="@dimen/activity_stream_base_margin"
                 android:layout_marginLeft="@dimen/activity_stream_base_margin"
                 android:layout_marginTop="@dimen/activity_stream_base_margin"
                 android:layout_marginBottom="@dimen/activity_stream_base_margin"
-                android:layout_gravity="center"
                 tools:background="@drawable/favicon_globe" />
 
     </FrameLayout>
 
     <ImageView
         android:id="@+id/menu"
         android:layout_width="32dp"
         android:layout_height="48dp"