Bug 1334086 - Change the SetOpenerWindow tabgroup assertion to a DIAGNOSTIC_ASSERT, r=ehsan
authorMichael Layzell <michael@thelayzells.com>
Fri, 24 Feb 2017 16:59:16 -0500
changeset 489618 32dce6ccde94a8c11a4de082e330656f1277b60f
parent 489617 eb97347c9690ad2f64890fe1f0f97c980e25f004
child 489619 a932a0a9cffe540eb552d662ad5dd033bdfd43e5
push id46871
push userbmo:sledru@mozilla.com
push dateSat, 25 Feb 2017 12:16:21 +0000
reviewersehsan
bugs1334086
milestone54.0a1
Bug 1334086 - Change the SetOpenerWindow tabgroup assertion to a DIAGNOSTIC_ASSERT, r=ehsan MozReview-Commit-ID: 13zUBotz7Tr
dom/base/nsGlobalWindow.cpp
--- a/dom/base/nsGlobalWindow.cpp
+++ b/dom/base/nsGlobalWindow.cpp
@@ -3443,17 +3443,17 @@ nsGlobalWindow::SetOpenerWindow(nsPIDOMW
   NS_ASSERTION(aOpener || !aOriginalOpener,
                "Shouldn't set mHadOriginalOpener if aOpener is null");
 
   mOpener = opener.forget();
   NS_ASSERTION(mOpener || !aOpener, "Opener must support weak references!");
 
   // Check that the js visible opener matches!
   nsPIDOMWindowOuter* contentOpener = GetSanitizedOpener(aOpener);
-  MOZ_RELEASE_ASSERT(!contentOpener || !mTabGroup ||
+  MOZ_DIAGNOSTIC_ASSERT(!contentOpener || !mTabGroup ||
     mTabGroup == Cast(contentOpener)->mTabGroup);
 
   if (aOriginalOpener) {
     MOZ_ASSERT(!mHadOriginalOpener,
                "Probably too late to call ComputeIsSecureContext again");
     mHadOriginalOpener = true;
     mOriginalOpenerWasSecureContext =
       aOpener->GetCurrentInnerWindow()->IsSecureContext();