Bug 1319237 - Calculate correct window position; r?automatedtester draft
authorAndreas Tolfsen <ato@mozilla.com>
Mon, 21 Nov 2016 23:33:03 +0100
changeset 479398 30c79f48453e1d5b07fb852288ab711688c2ebb4
parent 479397 3103d7cc3a5125865569dbd3fbc9f361148aab5f
child 479399 2d0d0f24a64757bc4e8b5d42b9028c7c0b9142ac
push id44243
push userbmo:ato@mozilla.com
push dateMon, 06 Feb 2017 16:11:43 +0000
reviewersautomatedtester
bugs1319237
milestone54.0a1
Bug 1319237 - Calculate correct window position; r?automatedtester The testing/marionette/browser.js window getter does not return the same window as `GeckoDriver#getCurrentWindow`. This is a problem, but for now we can rely on `getCurrentWindow`. MozReview-Commit-ID: PT9M7boPM7
testing/marionette/browser.js
testing/marionette/driver.js
--- a/testing/marionette/browser.js
+++ b/testing/marionette/browser.js
@@ -366,26 +366,16 @@ browser.Context = class {
   executeWhenReady(cb) {
     if (this.hasRemotenessChange()) {
       this.pendingCommands.push(cb);
     } else {
       cb();
     }
   }
 
-  /**
-   * Returns the position of the OS window.
-   */
-  get position() {
-    return {
-      x: this.window.screenX,
-      y: this.window.screenY,
-    };
-  }
-
 };
 
 /**
  * The window storage is used to save outer window IDs mapped to weak
  * references of Window objects.
  *
  * Usage:
  *
--- a/testing/marionette/driver.js
+++ b/testing/marionette/driver.js
@@ -1151,17 +1151,21 @@ GeckoDriver.prototype.getChromeWindowHan
 
 /**
  * Get the current window position.
  *
  * @return {Object.<string, number>}
  *     Object with |x| and |y| coordinates.
  */
 GeckoDriver.prototype.getWindowPosition = function (cmd, resp) {
-  return this.curBrowser.position;
+  let win = this.getCurrentWindow();
+  return {
+    x: win.screenX,
+    y: win.screenY,
+  };
 };
 
 /**
  * Set the window position of the browser on the OS Window Manager
  *
  * @param {number} x
  *     X coordinate of the top/left of the window that it will be
  *     moved to.