Bug 1460882 Disable SANDBOX_EXPORTS for the MinGW Build r?bobowen draft
authorTom Ritter <tom@mozilla.com>
Fri, 11 May 2018 08:16:13 -0500
changeset 795892 30b6e3ab5f15cde9f9b534db84e504f61aa50afe
parent 795891 efbcc205a0d3562691bf62bb0cb55bb7e891e8ff
child 795893 d9f6f8ec9de50c16bafd8ef611cefce14ed97be3
push id110108
push userbmo:tom@mozilla.com
push dateWed, 16 May 2018 18:43:56 +0000
reviewersbobowen
bugs1460882
milestone60.0.1
Bug 1460882 Disable SANDBOX_EXPORTS for the MinGW Build r?bobowen MozReview-Commit-ID: 2muTxIYUx6F
security/sandbox/moz.build
old mode 100644
new mode 100755
--- a/security/sandbox/moz.build
+++ b/security/sandbox/moz.build
@@ -151,19 +151,21 @@ elif CONFIG['OS_ARCH'] == 'WINNT':
             'chromium/sandbox/win/src/service_resolver_64.cc',
         ]
     else:
         SOURCES += [
             'chromium/sandbox/win/src/resolver_32.cc',
             'chromium/sandbox/win/src/service_resolver_32.cc',
         ]
 
-    for var in ('UNICODE', '_UNICODE', 'NS_NO_XPCOM', 'SANDBOX_EXPORTS',
+    for var in ('UNICODE', '_UNICODE', 'NS_NO_XPCOM',
                 '_CRT_RAND_S', 'CHROMIUM_SANDBOX_BUILD'):
         DEFINES[var] = True
+    if CONFIG['CC_TYPE'] != 'gcc':
+        DEFINES['SANDBOX_EXPORTS'] = True
 
     LOCAL_INCLUDES += ['/security/sandbox/chromium-shim']
     LOCAL_INCLUDES += ['/security/sandbox/chromium']
     LOCAL_INCLUDES += ['/nsprpub']
 
     DisableStlWrapping()
 
     # Suppress warnings in third-party code.