Bug 1233181: improve misleading log message about missing STUN & TURN servers. r?=mjf
authorNils Ohlmeier [:drno] <drno@ohlmeier.org>
Wed, 16 Dec 2015 12:00:27 -0800
changeset 340852 30aa01f38eb8cec76e48fb94f73233c2c217af43
parent 340851 1a3bff20682076f28f8003f8a4054b0e52de6f52
child 340853 8dcacd3fa6617952e01c42e162425a1205e59163
push id13079
push usergszorc@mozilla.com
push dateWed, 16 Mar 2016 02:22:26 +0000
bugs1233181
milestone48.0a1
Bug 1233181: improve misleading log message about missing STUN & TURN servers. r?=mjf MozReview-Commit-ID: sQzU9u96yP
media/mtransport/third_party/nICEr/src/ice/ice_ctx.c
--- a/media/mtransport/third_party/nICEr/src/ice/ice_ctx.c
+++ b/media/mtransport/third_party/nICEr/src/ice/ice_ctx.c
@@ -341,17 +341,17 @@ int nr_ice_ctx_create(char *label, UINT4
     if(r=nr_ice_random_string(buf,32))
       ABORT(r);
     if(!(ctx->pwd=r_strdup(buf)))
       ABORT(r);
 
     /* Get the STUN servers */
     if(r=NR_reg_get_child_count(NR_ICE_REG_STUN_SRV_PRFX,
       (unsigned int *)&ctx->stun_server_ct)||ctx->stun_server_ct==0) {
-      r_log(LOG_ICE,LOG_WARNING,"ICE(%s): No STUN servers specified", ctx->label);
+      r_log(LOG_ICE,LOG_DEBUG,"ICE(%s): No STUN servers specified in nICEr registry", ctx->label);
       ctx->stun_server_ct=0;
     }
 
     /* 31 is the max for our priority algorithm */
     if(ctx->stun_server_ct>31){
       r_log(LOG_ICE,LOG_WARNING,"ICE(%s): Too many STUN servers specified: max=31", ctx->label);
       ctx->stun_server_ct=31;
     }
@@ -363,17 +363,17 @@ int nr_ice_ctx_create(char *label, UINT4
         ABORT(r);
       }
     }
 
 #ifdef USE_TURN
     /* Get the TURN servers */
     if(r=NR_reg_get_child_count(NR_ICE_REG_TURN_SRV_PRFX,
       (unsigned int *)&ctx->turn_server_ct)||ctx->turn_server_ct==0) {
-      r_log(LOG_ICE,LOG_NOTICE,"ICE(%s): No TURN servers specified", ctx->label);
+      r_log(LOG_ICE,LOG_DEBUG,"ICE(%s): No TURN servers specified in nICEr registry", ctx->label);
       ctx->turn_server_ct=0;
     }
 #else
     ctx->turn_server_ct=0;
 #endif /* USE_TURN */
 
     ctx->local_addrs=0;
     ctx->local_addr_ct=0;