Bug 1227322 - Remove nightly flag from homepage pref. r=margaret draft
authorMichael Comella <michael.l.comella@gmail.com>
Mon, 23 Nov 2015 15:24:15 -0800
changeset 310777 2f2f97eb7abf9d978dd50051148e631dd1073da2
parent 310764 5f6ea7bb1641c89b4545f7b68f2378b2c172c7e3
child 511464 b869d380b6c79f9e6ca11dd95d78f2bd1a8bfbd4
push id7790
push usermichael.l.comella@gmail.com
push dateMon, 23 Nov 2015 23:24:23 +0000
reviewersmargaret
bugs1227322
milestone45.0a1
Bug 1227322 - Remove nightly flag from homepage pref. r=margaret It seems like too much work to make a full branded non-nightly build so I didn't strictly test this but I looked around the homepage code and saw no other blockers on set homepage.
mobile/android/base/preferences/GeckoPreferences.java
--- a/mobile/android/base/preferences/GeckoPreferences.java
+++ b/mobile/android/base/preferences/GeckoPreferences.java
@@ -672,23 +672,16 @@ OnSharedPreferenceChangeListener
             if (pref instanceof PreferenceGroup) {
                 // If datareporting is disabled, remove UI.
                 if (PREFS_DATA_REPORTING_PREFERENCES.equals(key)) {
                     if (!AppConstants.MOZ_DATA_REPORTING) {
                         preferences.removePreference(pref);
                         i--;
                         continue;
                     }
-                } else if (PREFS_CATEGORY_HOMEPAGE.equals(key)) {
-                    // Only enable the home page setting on Nightly.
-                    if (!AppConstants.NIGHTLY_BUILD) {
-                        preferences.removePreference(pref);
-                        i--;
-                        continue;
-                    }
                 } else if (PREFS_SCREEN_ADVANCED.equals(key) &&
                         !RestrictedProfiles.isAllowed(this, Restriction.DISALLOW_ADVANCED_SETTINGS)) {
                     preferences.removePreference(pref);
                     i--;
                     continue;
                 }
                 setupPreferences((PreferenceGroup) pref, prefs);
             } else {